I am getting the following warning `Boolean method 'isNotOnMetricSystem' is always inverted` even af...

# android

[lawlorslaw]

I am getting the following warning Boolean method 'isNotOnMetricSystem' is always inverted even after I changed to the following.

fun isNotOnMetricSystem(context: Context): Boolean {
        val country = getCountry(context)
        return country == context.getString(R.string.united_states_region_code)
    }

i previously had the inverse logic but that same warning. What do i have to change to in order to resolve the warning message?

[itnoles]

can getCounty to be null?

[lawlorslaw]

i previously had the logic on the left

[lawlorslaw]

i have it returning String

[itnoles]

some example = https://stackoverflow.com/questions/54988323/intellij-warning-boolean-method-foo-is-always-inverted

[lawlorslaw]

i tried this

fun getDistanceUnit(context: Context): DistanceUnit {
        val preferences = getSharedPreferences(context)
        
        val isOnImperialSystem = LocaleUtility.isOnImperialSystem(context)
        val defaultDistanceUnit =
            if (isOnImperialSystem) DistanceUnit.MILES else DistanceUnit.KILOMETERS
        
        return DistanceUnit.valueOf(
            preferences.getString(
                KEY_DISTANCE_UNIT,
                defaultDistanceUnit.toString()
            )!!
        )
    }

object LocaleUtility {

    fun isOnImperialSystem(context: Context): Boolean {
        val country = getCountry(context)
        return country == context.getString(R.string.united_states_region_code)
    }

    private fun getCountry(context: Context): String {
        val currentLocale = context.resources.configuration.locales.get(0)
        return currentLocale.country
    }
}

[lawlorslaw]

but i get this warning

[lawlorslaw]

same issue here

[Chrimaeon]

the warning is in the scope of where you call the method. are you using it with !isNotOnMetricSystem(context) ?

[lawlorslaw]

thats the thing. i am not negating when I am calling the function. i thinks its a bogus warning. probably a bug in their detection algo.