s changes just now

Question

< Marcello Galhardo> s changes just now have just been published to play store internal test be good to get as much testing as possible before we potentially promote

John O&apos;Reilly · Answer

< Marcello Galhardo> actually just testing a bit more and doesn t seem to start at anything earlier than 10 40am for some reason

John O&apos;Reilly · Answer

maybe something related to how time is being faked locally

Marcello Galhardo · Answer

It seems to be working for me thinking face

John O&apos;Reilly · Answer

are you changing time locally on phone

Marcello Galhardo · Answer

I m changing the `DateService now` return Let me try with the phone hour

Marcello Galhardo · Answer

< John O Reilly>

John O&apos;Reilly · Answer

so what I think I was seeing here is that it s applied to wrong date

John O&apos;Reilly · Answer

hmm or maybe not

Marcello Galhardo · Answer

The problem is that my previous calculation under certain conditions was collecting the wrong closest hour

Marcello Galhardo · Answer

The complexity bit here is that 1 We need to get the closest hour to the current hour 2 Each sticky header is also an item and have an index

Marcello Galhardo · Answer

So I need to get the closest hour item taking into account these index are separated per hour and each key is also an item +1 as it is used as a sticky header

Marcello Galhardo · Answer

Here is from my tests

John O&apos;Reilly · Answer

nice

John O&apos;Reilly · Answer

and you re seeing it applied to correct date thought I was seeing issue where it was applied to wrong date

John O&apos;Reilly · Answer

or maybe related to same issue

Marcello Galhardo · Answer

Hm what date issue

John O&apos;Reilly · Answer

let me test again and see for sur

Marcello Galhardo · Answer

I found a bug but it is because I m not considering out of the scope dates I will do yet another PR

Marcello Galhardo · Answer

For example 11 45 on Wednesday will open Thursday 11 45

John O&apos;Reilly · Answer

oh maybe that was it think I changed date to April 12th at some point

Marcello Galhardo · Answer

I will fix in the same PR please don t merge it yet

John O&apos;Reilly · Answer

k

John O&apos;Reilly · Answer

let me know when it s good to go and i ll publish an update

Marcello Galhardo · Answer

k

Marcello Galhardo · Answer

I tried here and it seems good Let me know if you find any issue < John O Reilly>

John O&apos;Reilly · Answer

this was using version from play store

Marcello Galhardo · Answer

A local build with these changes <https kotlinlang slack com archives C051P2HUVKP p1681153683516309 thread ts=1681152029 324879 amp cid=C051P2HUVKP|https kotlinlang slack com archives C051P2HUVKP p1681153683516309 thread ts=1681152029 324879 amp cid=C051P2HUVKP>

John O&apos;Reilly · Answer

so I have time set to 13th April 11am it shows 11 15 session at top but seems to for both 13th and 14th

Marcello Galhardo · Answer

What do you mean with for both

Marcello Galhardo · Answer

It opens on the right date and time and you change to the previous date and it keeps the hour

John O&apos;Reilly · Answer

yeah I see 11 15 session at top for 13th and 14th

Marcello Galhardo · Answer

Ah that was kind of by design but I can change

John O&apos;Reilly · Answer

yeah I think you d expect to see it show earliest session when you switch to 14th wdyt

Marcello Galhardo · Answer

Alright <https github com joreilly Confetti pull 588>