<@U0B8NBYNN>’s changes just now (<https://github...

# confetti

[John O'Reilly]

@Marcello Galhardo’s changes just now (https://github.com/joreilly/Confetti/pull/585) have just been published to play store (internal test)....be good to get as much testing as possible before we potentially promote.

[John O'Reilly]

@Marcello Galhardo actually, just testing a bit more and doesn't seem to start at anything earlier than 10:40am for some reason

[John O'Reilly]

maybe something related to how time is being faked locally....

[Marcello Galhardo]

It seems to be working for me. 🤔

[John O'Reilly]

are you changing time locally on phone?

[Marcello Galhardo]

I’m changing the DateService.now return. Let me try with the phone hour.

[Marcello Galhardo]

@John O'Reilly https://github.com/joreilly/Confetti/pull/587

[John O'Reilly]

so, what I think I was seeing here is that it's applied to wrong date?

[John O'Reilly]

hmm or maybe not

[Marcello Galhardo]

The problem is that my previous calculation “under certain conditions” was collecting the wrong “closest hour”.

[Marcello Galhardo]

The complexity bit here is that:
1. We need to get the “closest hour” to the current hour;
2. Each sticky header is also an item and have an index.

[Marcello Galhardo]

So I need to get the closest hour item, taking into account these index are separated per hour and each “key” is also an item (+1) as it is used as a sticky header.

[Marcello Galhardo]

Here is from my tests:

[John O'Reilly]

nice

[John O'Reilly]

and you're seeing it applied to correct date....thought I was seeing issue where it was applied to wrong date?

[John O'Reilly]

or maybe related to same issue

[Marcello Galhardo]

Hm, what date issue?

[John O'Reilly]

let me test again and see for sur

[Marcello Galhardo]

I found a bug, but it is because I’m not considering out-of-the-scope dates. I will do yet another PR.

[Marcello Galhardo]

(For example, 11:45 on Wednesday, will open Thursday 11:45).

[John O'Reilly]

oh maybe that was it....think I changed date to April 12th at some point

[Marcello Galhardo]

I will fix in the same PR, please don’t merge it yet.

[John O'Reilly]

k

[John O'Reilly]

let me know when it's good to go and i'll publish an update

[Marcello Galhardo]

k

[Marcello Galhardo]

I tried here and it seems good. Let me know if you find any issue @John O'Reilly

[John O'Reilly]

this was using version from play store?

[Marcello Galhardo]

A local build with these changes: https://kotlinlang.slack.com/archives/C051P2HUVKP/p1681153683516309?thread_ts=1681152029.324879&amp;cid=C051P2HUVKP

[John O'Reilly]

so, I have time set to 13th April 11am.....it shows 11:15 session at top....but seems to for both 13th and 14th

[Marcello Galhardo]

What do you mean with "for both"?

[Marcello Galhardo]

It opens on the right date and time, and you change to the previous date and it keeps the hour?

[John O'Reilly]

yeah, I see 11;15 session at top for 13th and 14th

[Marcello Galhardo]

Ah, that was kind of by design but I can change.

[John O'Reilly]

yeah, I think you'd expect to see it show earliest session when you switch to 14th....wdyt?

[Marcello Galhardo]

Alright. https://github.com/joreilly/Confetti/pull/588