This is going to sound very obvious, but I've always struggled with

collectAsState

… Assuming a function

fun foo(id: Int) = flow {
    expensiveNetworkRequest(id)
}.flowOn(<http://Dispatchers.IO|Dispatchers.IO>)

What is the correct way to collect it as state?

@Composable
fun Foo(id: Int) {
    // BAD: a new flow is created on each composition, leading to a recomposition loop
    val result1 by foo(id).collectAsState()

    // BAD: seems to also create a recomposition loop
    val result2 by remember(id) { foo(id) }.collectAsState()

    // GOOD?
    val result3 by remember(id) { foo(id).collectAsState() }

    Text(resultX)
}

Is there a reason you need to call foo in this Composable? Why not put it in a VM and pass the state in?

ViewModel is Android-only, right?

Android has a ViewModel class yes, but the concept applies generally

How would you write this example in a multiplatform way?

result2

should be fine. What you say is a ‘recomposition loop’ is probably recomposition due to state emission

That's indeed what I want, but last time I tried it looped infinitely 🤔

if you are using ‘result2’, it can only loop ‘indefinitely’ if the key changes indefinitely

I'll try again and check how it works. Thanks

if you want to make sure, just copy the ‘collectAsState’ function, and place a log inside the produceState block

val result by produceState(initialValue) {

foo(id).collect { value = it }

}

Thats what collectAsState do