1. Documentation - is my second little issue with koin: The good part is, that there is a fair amou...
e
2. Documentation - is my second little issue with koin: The good part is, that there is a fair amount of documentation. However, I think it could be improved a lot: β€’ there are a lot of typos and grammar errors - pretty irrelevant as far as content is concerned, but to me it makes a bad impression (don't know how others feel about it, though) β€’ maybe it's just me, but some things could be explained a bit better. Even after reading some sections a couple of times, I still don't get it. (I'll try and talk about specific examples later.) β€’ the documentation seems a bit anecdotal to me - I feel like there is not much difference in between the "Tutorials" and the "Documentation". To put my actions where my mouth it, I tried to improve the "Core" sections of the documentation a little. Would be nice the get some feedback on the PR: https://github.com/InsertKoinIO/koin/issues/1564 I hope to go over other sections in the doc if this is welcome.
πŸ™Œ 1
p
for developer and contributions you might want to post this in #koin-dev
p
@arnaud.giuliani I revised this PR and added some β€œHere” comments in my code review. I think you could just give a look in these comments and approve it. :)
p
from Pedro do Pedro @Pedro Francisco de Sousa Neto can you also take a look https://github.com/InsertKoinIO/koin/pull/1560
p
Approved too, @Pedro Alberto! πŸ˜‰
a
thanks guys for your help πŸ™‚ recovering from conference time, will be back on review soon πŸ˜„
just repushed main branch with last docs guys, if you can take a look