<@U33H6SB2B> bumping versions of `kotlin-wrappers`...
# javascript
p
@turansky bumping versions of
kotlin-wrappers
with e.g Renovate and auto-merge enabled is broken, see https://github.com/typesafegithub/github-workflows-kt/pull/791 - it keeps failing with
yarn.lock was changed. Run the kotlinUpgradeYarnLock task to actualize yarn.lock file
and a manual action is needed for each PR. Is it a known issue? I can imagine some extra automation that regenerates
yarn.lock
. I'm wondering if this issue is tackled in any way
j
You can write a GitHub action that detects renovate PRs, checks them out, runs that task, and pushes to their branch if there are changes
Renovate also has a feature to run post-upgrade tasks but it only works on self-hosted installs and not the global one
Well it works on the global one but they have an allowlist of the command you can run and arbitrary gradle commands is not one of them.
p
yeah, I can always have a custom workflow, I was just wondering if there’s some e.g. reusable GH action or GH app that solves this
j
p
why does it trigger for a comment under an issue? https://github.com/cashapp/redwood/blob/8ea6f81e20bddb28e206c1e37c69c6237da3dc2e/.github/workflows/command.yaml#L4-L6 I thought it’s about Renovate PRs
j
Yeah we decided to change it. There's no need to run the task for 99% of renovate PRs.
Instead on the 1% where it causes a build failure I'll comment "/yarn" and the workflow will run and push a commit.
p
sure, better than nothing. is there a way to trigger the workflow if any of the PR checks fails?
j
I honestly didn't look. I left a comment in the PR saying that would be ideal.
👍 2