eygraber
04/26/2023, 10:40 PMLazyListScope
expected to be UpperCamelCase? I know they aren't composable functions, but they wrap them in a lot of cases (i.e. they hide calls to item
or items
inside of them) and so it looks weird in a composable function to see a function call that looks like it will emit UI, but named in lowerCamelCase.Travis Griggs
04/26/2023, 11:02 PMLoney Chou
04/27/2023, 1:16 AMJob()
, SerializersModule {}
) and @Composable functions that emit UI are named UpperCamelCase. If it itself isn't @Composable, it should be named in lower, and if it is @Composable but doesn't emit UI, it's also named lower.eygraber
04/27/2023, 1:17 AMLoney Chou
04/27/2023, 1:23 AMBox
inside LazyListScope
?".eygraber
04/27/2023, 2:11 AMreportItems
looks out of place here.
Box {
LazyColumn {
reportItems()
}
}
fun LazyListScope.reportItems() {
items(...) {
Card(...)
}
}
dewildte
04/27/2023, 7:35 PMstickyHeader
is basically the same idea, and it is lowercase.
Just like item {…}
and items(…) {…}
.LazyListScope
but .reportItems
feels like its specific to a particular UI that shows `Report`s.
maybe it should be internal
or private
?eygraber
04/27/2023, 7:45 PMdewildte
04/27/2023, 9:34 PMprivate
is the case then that seems totally fine.