Hello everyone, i am new to ktor and would like to get help about this code: ```post("api/auth/endp...

# server

[Eman]

Hello everyone, i am new to ktor and would like to get help about this code:

post("api/auth/endpoint") {

// start - block of code that is repeated
  val principal = call.principal<JWTPrincipal>()
        val userId = principal?.getClaim("userId", String::class)
        if (userId == null) {
            call.respond(
                HttpStatusCode.Forbidden,
                CyrCloError(401, "User not authenticated. Please login in again")
            )
            return@post
        }
// end
}


how can this code refactored? because i have been keep repeating that code to my other endpoints

Thanks,

[edrd]

There are several options, but I think the best one is to use the Authentication plugin: https://ktor.io/docs/authentication.html#authenticate-route

[Eman]

yes thanks, i am using jwt authentication,

[Eman]

but i want to refactor the block that gets the userId, so that method i can re-use in other routes

[edrd]

Oh, sorry

[edrd]

You could create an extension function that receives the user, like:

@JvmInline
value class UserId(val value: String)

fun <http://Routing.post|Routing.post>(path: String, handle: (UserId) -> Unit) {
  post(path) {
    val principal = ...
    val userId = ...
    // ... null check + return
    handle(userId)
  }
}

// Then in your routers

post("/api/auth/endpoint") { userId ->
  doSomething(userId)
}

[edrd]

However, if the userId claim is always required, you should probably move this check to the validate method of the JWT authenticator

[Eman]

...thanks...i will try your suggestion

[Eman]

call is not available?

[edrd]

Change handle to ApplicationCall.(UserId) -> Unit

[edrd]

Actually, there’s a recursion going on

[edrd]

I think

[edrd]

Yep, you need to import Ktor’s `post`…

[Eman]

image.png

[Eman]

...i don't if this will work?

[Eman]

im ending up extending the ApplicationCall with something like this:

suspend fun ApplicationCall.getUserId(handleUser: (String) -> Unit) {
    val principal = principal<JWTPrincipal>()
    val userId = principal?.getClaim("userId", String::class)
    if (userId == null) {
        respond(
            HttpStatusCode.Forbidden,
            CyrCloError(401, "User not authenticated. Please login in again")
        )
        return@getUserId
    }
    handleUser(userId)
}