Marcin Wisniowski
05/01/2023, 9:20 PMDisposableEffect
with an empty onDispose {}
. What is the reasoning behind it? One example is here: https://google.github.io/accompanist/systemuicontroller/#usageorangy
05/01/2023, 9:29 PMCompositionEffect
and the callback called onDecompose
it could be more clear, that it’s a “lifecycle” thing rather than necessarily the disposable thing.Alex Vanyo
05/01/2023, 9:36 PMonDispose
block).
Window flags are a really awkward API to work with from the perspective of Compose.mattinger
05/02/2023, 3:01 AMLoney Chou
05/02/2023, 3:20 AMSideEffect
are built upon RememberObserver
, which can be invalidated by key
parameter, so the block will only be executed when something has changed. I'd suggest having another SideEffect
which is also built this way, so no empty onDispose
workaround any more. Anyway, it's more of a semantic issue.