Hey there! I made my first contribution, which imp...

# koin-contributors

[Marc Reichelt]

Hey there! I made my first contribution, which improves an error message of the checkModules functionality:
• Issue: https://github.com/InsertKoinIO/koin/issues/1569
• PR: https://github.com/InsertKoinIO/koin/pull/1570
Is there anything else that I should do for it to be mergeable?

[Pedro Francisco de Sousa Neto]

PR approved by me, an contributor. But requires approval from a maintainer too.

[Marc Reichelt]

Thank you :)

[Marc Reichelt]

And I see online that the commit probably needs to be signed, too

[arnaud.giuliani]

great 🙂

[Marc Reichelt]

It’s signed + verified now - nice, I learned something new 🙂

[Pedro Francisco de Sousa Neto]

@Marc Reichelt the error in sample was fixed. Please, update your branch.

[Marc Reichelt]

Thanks! Trying to, but it seems GitHub is down right now. Will try later!

[Marc Reichelt]

@Pedro Francisco de Sousa Neto GitHub is back up, so the push succeeded. All systems go ✅

[Marc Reichelt]

Anything more that I need to do for https://github.com/InsertKoinIO/koin/pull/1570, or just waiting for approval? @arnaud.giuliani

[Pedro Francisco de Sousa Neto]

I think so. 🙂

[Marc Reichelt]

Ok, thanks! I just wanted to make sure everything is done from my side :)

[arnaud.giuliani]

running

[arnaud.giuliani]

image.png

[Marc Reichelt]

Thank you very much - yay, my first Koin contribution made it! 😊

[arnaud.giuliani]

thank you 🙂