https://kotlinlang.org logo
Title
m

Marc Reichelt

05/02/2023, 9:22 AM
Hey there! I made my first contribution, which improves an error message of the
checkModules
functionality: • Issue: https://github.com/InsertKoinIO/koin/issues/1569 • PR: https://github.com/InsertKoinIO/koin/pull/1570 Is there anything else that I should do for it to be mergeable?
p

Pedro Francisco de Sousa Neto

05/02/2023, 2:37 PM
PR approved by me, an contributor. But requires approval from a maintainer too.
m

Marc Reichelt

05/02/2023, 4:16 PM
Thank you :)
And I see online that the commit probably needs to be signed, too
a

arnaud.giuliani

05/02/2023, 7:23 PM
great 🙂
m

Marc Reichelt

05/02/2023, 9:42 PM
It’s signed + verified now - nice, I learned something new 🙂
p

Pedro Francisco de Sousa Neto

05/04/2023, 12:57 PM
@Marc Reichelt the error in sample was fixed. Please, update your branch.
m

Marc Reichelt

05/04/2023, 4:09 PM
Thanks! Trying to, but it seems GitHub is down right now. Will try later!
@Pedro Francisco de Sousa Neto GitHub is back up, so the push succeeded. All systems go
Anything more that I need to do for https://github.com/InsertKoinIO/koin/pull/1570, or just waiting for approval? @arnaud.giuliani
p

Pedro Francisco de Sousa Neto

05/08/2023, 6:53 PM
I think so. 🙂
m

Marc Reichelt

05/08/2023, 9:31 PM
Ok, thanks! I just wanted to make sure everything is done from my side :)
a

arnaud.giuliani

05/09/2023, 2:19 PM
running
image.png
m

Marc Reichelt

05/09/2023, 2:40 PM
Thank you very much - yay, my first Koin contribution made it! 😊
a

arnaud.giuliani

05/09/2023, 2:57 PM
thank you 🙂