https://kotlinlang.org logo
Title
j

jmfayard

05/25/2023, 9:45 AM
script-generator: what are the most important things that needs to be fixed? @Piotr Krzemiński and everyone I am flying back tomorrow from vacation Tokyo-> Hong-Kong -> Paris So I will have much more time than usual. But also I have no internet and needs to know al the infos before my plane goes in the air
I made a branch
resurrection
just before the commit that removes the script-generator and was able to make it work with the samples from the project
What are the most important library features that are missing?
What are some simple workflows that didn’t work?
p

Piotr Krzemiński

05/25/2023, 12:10 PM
@jmfayard I understood the below message like you being unable to own the script-generator, did we have a misunderstanding? https://kotlinlang.slack.com/archives/C02UUATR7RC/p1683799224971449?thread_ts=1683795776.614379&cid=C02UUATR7RC
would it be fine with you to have the script-generator in a separate repo? I’ll leave the internal API exposed by the library. As I wrote in https://kotlinlang.slack.com/archives/C02UUATR7RC/p1684750095105069, there are some advantages in not having the script generator in the same repo and after the removal I like how the repo became more lightweight. The script-generator seems like a separate product/tool, so it makes sense to me to have it separate. We can have another repo under typesafegithub org
answering your questions directly: it’s hard for me to answer, I recall 2 tickets (I resolved them as wontfix several days ago) which were tracking some missing features, but it would be good to analyze missing features in a generic way
j

jmfayard

05/25/2023, 2:06 PM
Piotr: it was impossible for me to program while travelling in Japan But I just realized I will have lots of otherwise boring hours in the flight Japon -> France itself I’m fine with having a separate repo, but my goal is to do the coding part during the flight who starts in 24h00 so I will work on things as they are
p

Piotr Krzemiński

05/25/2023, 5:17 PM
it’s hard for me to distill particular coding tasks within such short time, so maybe try to split the script generator to another repo?
j

jmfayard

05/27/2023, 2:23 PM
It’s a massively long flight. I have done Tokyo -> HongKong, with 10 hours waiting in HongKong I was able to lots of progress already HongKony -> Paris still to go
p

Piotr Krzemiński

05/29/2023, 12:29 PM
cool, I’ve been thinking about a name for the new repo, script-generator is very vague. How about “yaml-to-kotlin-workflow-converter” so that it’s clear about the responsibility? if you want to use some given name, let me know!
j

jmfayard

05/30/2023, 7:28 AM
I have renamed the module to kotlin2yaml I didn’t work on extracting to a new repo, partly because kotlin2yaml depends not only on the library but also on the typings and on the wrapper generator most importantly because it seemed more important to make it work the kotlin2yaml part is working pretty well now, I want to document its limitation and be done with it
p

Piotr Krzemiński

05/30/2023, 8:46 AM
I’d really like to have it in a separate repo, it’s an architecture decision I want to stay with. Let’s discuss the dependencies on the typings and the wrapper generator with an intent to remove it, I’m keen to help with extracting kotlin2yaml