<@U33H6SB2B> when I look at what you commit on the...

# javascript

[Edoardo Luppi]

@turansky when I look at what you commit on the kotlin-wrappers repo I see that pretty much every commit is generated. Does that mean you're using the last version of Dukat without editing manually?

[hfhbd]

The converter used by Kotlin wrappers does not base on dukat: https://github.com/karakum-team/karakum.
This converter is used by this repo https://github.com/karakum-team/types-kotlin to actually generate the code for Kotlin-wrappers.

[Edoardo Luppi]

@hfhbd ahhhhh! Now it makes sense. The stuff I was getting out of Dukat looked so much different

[Vampire]

Yeah Dukat is greatly unattended and in 1.8.20 even the Dukat integration in the Kotlin Gradle Plugin was removed.

[Vampire]

We'll see whether it gets some love again in the future

[Edoardo Luppi]

@hfhbd I wonder then how I can contribute typings.
Example: I'm missing Node TLS module

[turansky]

In theory
1. Update generator types-kotlin - PR
2. PR in kotlin-wrappers (copy generated sources)

[Edoardo Luppi]

@turansky could you point out a class/build file I can start from?
Then I can probably figure out the rest myself.

Just a question: I see Node is already included in the generation, but why some modules are not done? Do you have to enable module by module?

[turansky]

Do you have to enable module by module?

Yes

[Edoardo Luppi]

Ok I've probably found it https://github.com/karakum-team/types-kotlin/blob/25d68425ceee8f6902214d3662b26137e3671e2b/buildSrc/src/main/kotlin/karakum/node/Generator.kt#L69

[Edoardo Luppi]

@turansky tried building with gradle build as in CI
Is this expected?

[Edoardo Luppi]

Other question: if I re-generate Node types, the formatting is screwed up.
Do you do that manually in the IDE afterwards?

[turansky]

1. Error is expected - big update for kotlin-browser is in progress
2. Yes, we format code in IDEA
3. For development you can run build on subproject

[turansky]

Error I will fix today

[Edoardo Luppi]

No problem for the error.
I think there is a missing project formatting option tho: after I imported the project, re-generated Node types and formatted, I'm missing trailing commas. I had to enable them manually.

So basically what I should aim for is the generation should not have errors, all the rest can be done manually, is this correct?

[Edoardo Luppi]

So I've been able to generate the TLS module, but not without issues:
1. X509Certificate from Crypto is missing. Debugging the Gradle build freezes the IDE
2. some parameter or return types are referenced as, e.g., net.Socket while the node.net.Socket symbol is already imported
3. Overloaded functions conflicts

[turansky]

types-kotlin compilation fixed