Alessandro Marcolini
06/30/2023, 6:28 PMMenu
item?Nick
06/30/2023, 7:28 PMMenuBehavior
. take a look at how this is done in BasicMenuBehavior.Nick
07/01/2023, 6:11 AMAlessandro Marcolini
07/01/2023, 9:17 PMAlessandro Marcolini
07/01/2023, 9:18 PMPathMetrics
instance?Nick
07/01/2023, 9:26 PMModule(name = "App Module") {
//…
bind<PathMetrics> () with singleton {
PathMetricsImpl(instance())
}
//…
}
Nick
07/01/2023, 9:27 PMMenu
but opted to ship and see how common it was. sounds like it might be worth considering.Alessandro Marcolini
07/02/2023, 3:22 PMBasicMenuBehavior
requires a PathMetrics
instance, but no modules provide a binding for it. Is that expected behavior?Alessandro Marcolini
07/02/2023, 4:52 PMprintln
in BasicMenuBehavior
here, which looks like maybe old logging information? I could make an issue for it but it seems like a really easy fix.Nick
07/02/2023, 5:15 PMPathMetrics
impls depending on which platform you’re using. so the Themes
library, which is common
cannot include the binding and must rely on the app to chose. this is something that might need better documentation though.
i think i’ve already discovered and fixed the old println
for the next release. but thanks for raising it.