Sorry for being such a nit, but I just realized, t...
# http4ko
Oliver Eisenbarth
07/06/2023, 11:26 AMSorry for being such a nit, but I just realized, that the AWS guide says: "This module provides 2 things", but the second point ("super-simple AWS request signing..."), which is correct in the markdown file .../reference/aws/index.md, somehow gets rendered as "1". Can't help but see such things, when scanning documents. 🙇
f
fredrik.nordin
07/06/2023, 12:15 PMI'm sure a PR to correct any documentation issues you find would be very much appreciated 😇
o
Oliver Eisenbarth
07/06/2023, 12:26 PMDon't know how to fix.
Even the GH preview renders "2" correctly as "2", but somehow it ends up as a "1" on the deployed site.
d
dave
07/06/2023, 12:31 PMIt will probably be a blank line between the 2 options. That should be able to preview it inside GitHub in the live markdown view
o
Oliver Eisenbarth
07/06/2023, 2:43 PMATM I am hoping that my cheap laptop ever finishes running Gradle check...guess I'll make this a weekend task for myself. 😁
Oliver Eisenbarth
07/06/2023, 3:52 PMCould someone help me out with contributing? I've forked the http3k-repo, made a branch and a PR on my own repo that has http4k as upstream...what do I need to do now?
d
dave
07/07/2023, 5:12 AMYour upstream isn't set to the correct repo. You need to change it to reference the original http4k/master repo instead of your own master branch. At the moment this means you have "asked" to merge into your own master.
The simplest thing would be to just merge your current PR into your forks master and then raise another PR from there onto ours.
Generally you'd raise PRs from your fork master to the target 🙃
https://github.com/Alfhir/http4k/pull/1
o
Oliver Eisenbarth
07/07/2023, 11:11 AM😊
Thank you very much for letting me practice contributing to OSS @dave .