Never exported an enum before, so I've tried in my MP project. This compiles fine from `commonMain`....

# javascript

[Edoardo Luppi]

Never exported an enum before, so I've tried in my MP project.
This compiles fine from commonMain. Weren't enum exports prohibited?

[AndreiBogdan]

Pfff .. I updated kotlin and yeah, no warning. But yeah ... I also read that they were prohibited. What would be a plan B then, if not enums ? What's the best practice ?

[Edoardo Luppi]

@AndreiBogdan that's actually a good question. Being I've never exported/used enums in my MPP as of now, I'd also like to understand what's the general consensus

[Artem Kobzar]

Export enums should be okay. The only problem is to define external enums, in the new 1.9.0 Kotlin

[AndreiBogdan]

Perfect. THank you very much !

[AndreiBogdan]

i also have another issue ....

@JsExport
object SharedUserManagerJs {

    fun saveUserToken(userToken: String?) {
        SharedUserManager.saveUserToken(userToken)
    }
}

[AndreiBogdan]

this can not be found by my React colleague when importing the library

[AndreiBogdan]

there are 2 object classes that i exported, neither are visible to him in the web app code ...

[AndreiBogdan]

why is that ?!

[Edoardo Luppi]

Thanks @Artem Kobzar! I think docs need to be updated to remove the

It is currently prohibited to export the following kinds of declarations:

• enum classes

https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.js/-js-export/

[Edoardo Luppi]

@AndreiBogdan are you exporting using CommonJS modules or native ES modules?
I can see it generates the correct JS code

function SharedUserManagerJs() {
  SharedUserManagerJs_instance = this;
}
protoOf(SharedUserManagerJs).saveUserToken = function (userToken) {
  println(userToken);
};

[AndreiBogdan]

js(IR) {
    moduleName = "kmm-lib"
    nodejs {
        binaries.library()
    }
    useCommonJs()
}

[AndreiBogdan]

is that why? because i'm using useCommonJs() ?

[AndreiBogdan]

what's the other option, if not useCommonJs()?

[AndreiBogdan]

to be frank, i'm not 100% sure what useCommonJs() does 😄 😄 perhaps you could elucidate this mistery as well a bit 😄

[Edoardo Luppi]

https://en.wikipedia.org/wiki/CommonJS explains what it is pretty well.
the other option is useEsModules. It seems to me ES modules are what the future of Node is anyway, and maybe what Kotlin will aim to get better at (correct me if I'm wrong on this tho).

[Edoardo Luppi]

React colleague

Mmm, why are you using

nodejs {
  binaries.library()
}

? Shouldn't you target the browser?

[AndreiBogdan]

hmm, so what's the other option besides useCommonJs() then ?

[AndreiBogdan]

I'm using binaries.library() 'cause i just need to expose the business layer to the react web app. We've already got a web app setup, they're doing their own tuff there, i just need to expose some logic for them. same as i'm doing for iOS in fact.