is there a util function for adding a <Duration> t...

# kotlinx-datetime

[Adam S]

is there a util function for adding a Duration to a LocalDate or LocalDateTime?

[ephemient]

that wouldn't have a well-defined result at DST changes and other timezone definition changes

[ephemient]

if you don't care about that, I suppose you could

localDateTime.toInstant(TimeZone.UTC).plus(duration).toLocalDateTime(TimeZone.UTC)

but it raises the question of why would you be doing these operations with a Local* instead of an Instant?

[Adam S]

cool thanks, that seems to work

operator fun LocalDate.plus(duration: Duration): LocalDate =
    atStartOfDayIn(TimeZone.UTC).plus(duration).toLocalDateTime(TimeZone.UTC).date

operator fun LocalDateTime.plus(duration: Duration): LocalDateTime =
    toInstant(TimeZone.UTC).plus(duration).toLocalDateTime(TimeZone.UTC)

[Adam S]

but it raises the question of why would you be doing these operations with a Local* instead of an Instant?

I’m updating some Java time code. My experience in Java is that Instant is awkward and difficult to use, but maybe my prejudice doesn’t apply to a Kotlin Instant?

[ephemient]

LocalDateTime + Duration is not something that can be done without knowing the TimeZone. 2023-03-12 01:30 + 1 hour = 2:30 in most parts of the world but 3:30 in most parts of the US

[ephemient]

yes, Instant can be awkward when you want human times, but human times are a pain. you need Instant or ZonedDateTime (which kotlinx-datetime doesn't have) to actually perform most operations.

[Sam Stone]

@ephemient so you can't actually perform most operations in KotlinX date-time?

[ephemient]

how do you get that from what I said?

[ephemient]

kotlinx-datetime has TimeZone and Instant which is all a ZonedDateTime really is

[Sam Stone]

https://kotlinlang.slack.com/archives/C01923PC6A0/p1688909668283709?thread_ts=1688900739.162529&amp;cid=C01923PC6A0

you need ... ZonedDateTime (which kotlinx-datetime doesn't have) to actually perform most operations.

[Adam S]

I would read that as:

you need Instant (if using kotlinx-datetime or java.time) or ZDT (if using java.time) to perform most operations

[ephemient]

obviously both kotlinx-datetime and java.time have Instant. only java.time has ZDT, but it is mostly isomorphic to a pair of (Instant, ZoneId), and you don't need another structure to do that in Kotlin.