Just setup GH Pages workflow to build/deploy the W...

# compose-web

[John O'Reilly]

Just setup GH Pages workflow to build/deploy the Wasm based Compose for Web app but getting this for some reason. I'm deploying from compose-web/build/dist/wasm/productionExecutable ....is this correct or is there some additional setup needed?

[Big Chungus]

The dir is correct at least

[mbonnin]

I had the same issue on https://wasm.confetti-app.dev/, had to manually copy Confetti.uninstanciated.mjs to the productionExecutable dir

[John O'Reilly]

I guess I can add that copy to the GH action for now

[John O'Reilly]

I updated action (https://github.com/joreilly/chip-8/blob/main/.github/workflows/build-and-publish-web.yml) to copy over that file....and do see it in brach (https://github.com/joreilly/chip-8/tree/gh-pages) but getting different errors now

[John O'Reilly]

hmm, seems to be issue getting that ch8 file....though that seems to be there

[John O'Reilly]

looks to be issue with relative path used .....it's trying to load https://joreilly.github.io/Space%20Invaders%20[David%20Winter].ch8 whereas it should be https://joreilly.github.io/chip-8/Space%20Invaders%20[David%20Winter].ch8

[mbonnin]

if (te == null) {
    document.getElementById("warning").style.display="none";
} else {
    throw te;
}

I think you can remove that part (or add the matching div)

[mbonnin]

(for the 1st error)

[mbonnin]

For the 2nd, ressource forces an absolute path for some reason: https://github.com/JetBrains/compose-multiplatform/blob/1346feea5a52f6c2f76373f253[…]rc/jsMain/kotlin/org/jetbrains/compose/resources/Resource.js.kt

[mbonnin]

Ping @Dima Avdeev could we remove that leading / and have XHRs that support relative paths? (from the JSResourceImpl)

[John O'Reilly]

I'm going to do quick test at least deploying code that uses chip-8/ at start of resource just to see that there's no other issues....

[John O'Reilly]

ok works at least with that change (but needs better solution of course) https://joreilly.github.io/chip-8/

[John O'Reilly]

still as slow as ever but that's a separate thing I need to look at

[mbonnin]

Also: we need a leadearboard 😉

[John O'Reilly]

I was just thinking exactly the same thing 😃

[mbonnin]

I've reached level 2 once 😄!

[John O'Reilly]

I'll add option to select a few more ROMs as well at some point

[John O'Reilly]

I ported original JVM based implementation across to be KMP based and did crude update of some the threading code that it was using to allow it to run there.....but probably needs some rework.....that might help address some of the performance issues

[John O'Reilly]

but fwiw it certainly runs a lot more smoothly on Compose for Desktop

[Dima Avdeev]

Ping @Dima Avdeev could we remove that leading / and have XHRs that support relative paths? (from the JSResourceImpl)

As I correctly understand, we need to fix resource path on JS side ?

[Dima Avdeev]

I can create an Issue for that

[mbonnin]

Yep, looks like it would work if we just removed the / :

req.open("GET", path, true)

[mbonnin]

But maybe there's more to it, I'm not super familiar with that code

[mbonnin]

Especially, looks like the leading / was added on purpose: "/$path" . So maybe it's something to do with the XHR API or something else?

[Dima Avdeev]

Ok, thanks! I will create an Issue to understand what we can do with it on JS

[mbonnin]

Thanks!

[Dima Avdeev]

Created here: https://github.com/JetBrains/compose-multiplatform/issues/3413