Can't seem to figure out why sometimes I need `pri...

# koin

[Colton Idle]

Can't seem to figure out why sometimes I need
private val foo by inject<Foo>(Foo::class._java_)
but sometimes I can have
private val foo by _inject_<Foo>()
anyone know? (sorry koin noob)

[arnaud.giuliani]

wrong import?

[curioustechizen]

Yeah you should never need the former.

[Colton Idle]

Weird. I'm in the same gradle module. so it shouldnt be a missing dependency issue. i tried transplanting the import from one file to another but it can't resolve inject

ill keep debugging

[Javier]

the dispatch receiver (this) is correct?

if not you aren’t in an activity or fragment, and you must extend from KoinContext (or even better using constructor injection)

[Colton Idle]

So for example,

private val api: MyApi by inject(MyApi::class.java) is in an android viewModel

class MyVM : ViewModel() {

private val api: MyApi by inject(MyApi::class.java)

[Colton Idle]

ah. so if I make my ViewModel a KoinComponent then I can use the shortened inject method

[Javier]

pass it via constructor

[Colton Idle]

k. wonder if it'll "just work"

[Javier]

it would work, but it is a bad practice, the only reason to use inject is when you are not able to instantiate the classes, if not, they should be injected via parameters

not sure if Koin is addressing this issue in Android, but, nowadays, there is no reason to not inject everything via constructors, even in Activities and Fragments except due some legacy limitation

[Javier]

https://marcellogalhardo.dev/posts/injection-points/

[Javier]

image.png

[Javier]

it should be "trivial" for Hilt or Koin to codegen a custom AppComponentFactory which you can put on the manifest

<application android:appComponentFactory=".HiltOrKoinCodegenComponentFactory" />

Which should allow to inject everything via constructor

[Javier]

The main limitation can be Starting from API Level 28

[Colton Idle]

thanks. i think my original question is now resolved due to the fact that I didn't know that I should implement the KoinComponent interface. then the short inject method works.

Ill try to look up the best practices for koin and AAC VMs

[Colton Idle]

thanks all