Hello! I’ve made a couple of minor contributions t...
# detekth
Harold Martin
07/30/2023, 3:52 PMHello! I’ve made a couple of minor contributions to detekt in the past but wanted to create a new ruleset. I’d love some feedback from here, especially on the rule implementations 🙏 https://github.com/hbmartin/hbmartin-detekt-rules
b
Brais Gabin
07/31/2023, 6:48 AMThe psi is a complex api. I wouldn't care too much of the implementation is the best one. If the tests are green, everything is good. And as soon as you find something strange, more tests and refine.
Apart from that the rules looks good. :)
gratitude thank you 1
s
schalkms
07/31/2023, 3:13 PMRuleset looks good 👍
I think your ruleset deserves to be included in the detekt market place to gain more visibility in the community. May I ask you to submit a PR?
schalkms
07/31/2023, 3:14 PMh
Harold Martin
07/31/2023, 7:58 PM@Brais Gabin thank you!
@schalkms done! https://github.com/detekt/detekt/pull/6348