Question out of curiosity. Is there a reason to ha...

# javascript

[Edoardo Luppi]

Question out of curiosity. Is there a reason to having the tmp variable in the middle?

val otherBuffer = if (otherBytes is Buffer) {
  otherBytes
} else {
  Buffer.from(otherBytes)
}

Is translated to

var tmp;
if (otherBytes instanceof Buffer) {
  tmp = otherBytes;
} else {
  tmp = Buffer.from(otherBytes);
}
var otherBuffer = tmp;

Why not assign directly to otherBuffer ?

[jw]

Because generating the expression if and assigning a variable to another are implemented separately in the lowering to JS

[jw]

The assumption is that you use a post-processor to compact the JS which will eliminate the intermediate variable

[Edoardo Luppi]

@jw makes sense, thanks!

[Ayfri]

Is there any existing post processor doing that ?

[jw]

Tons. The JS ecosystem has 10 tools for everything

[jw]

Uglify, minify, terser, scissors, probably more

[jw]

Run the production bundle and terser should already be running via webpack

[Edoardo Luppi]

I think you can customize the WP configuration to run whatever tool you prefer

[Haroon Iftikhar]

Atwood’s law ftw

[Artem Kobzar]

Also, starting from 1.9.0 we are doing also such kind of "optimizations" of JS and with 1.9.20 there will be more of them.

[Edoardo Luppi]

Thanks @Artem Kobzar, looking forward the final release of 1.9.20.
As I mentioned in another thread, I've also seen performance improvements between 1.8.22 and 1.9.0. Hopefully more will come.