<@U035683KFAM> Opening another :thread: about `SpringAutowireConstructorExtension` Vs. `SpringExtens...

Giorgio Vespucci

09/05/2023, 3:13 PM

@Chris Lee Opening another 🧵 about

SpringAutowireConstructorExtension

Vs.

SpringExtension

Giorgio Vespucci

09/05/2023, 3:14 PM

btw, that extension should likely be this:

Copy code

override fun extensions(): List<Extension> {
    return listOf(SpringAutowireConstructorExtension)
}

…unless you intend to apply

SpringExtension

to all test specs (above matches what kotest auto-configures).

Giorgio Vespucci

09/05/2023, 3:14 PM

Could you please elaborate?

Chris Lee

09/05/2023, 3:19 PM

When I disabled auto-scan for configurations and extensions several Spring-based tests broke. I added

SpringExtension

into the Kotest config class - that broke many other non-Spring tests. From looking at the kotest config dump (w/ autoscan enabled) aligned on using

SpringAutowireConstructorExtension

to match what kotest had previously provided.

sam

09/05/2023, 3:30 PM

We might want a better way for extensions to auto register themselves, either using the ServiceLoader framework in Java, or by using a well defined class name.

👍 1

sam

09/05/2023, 3:30 PM

I might remove the warning about auto scan in 5.7.2, it seems premature to add it given the noise that's coming up around it

Chris Lee

09/05/2023, 3:30 PM

@Giorgio Vespucci you will need to add in the

SpringAutowireConstructorExtension

to match what kotest had auto-discovered; see if that fixes your test-detection issue.

Chris Lee

09/05/2023, 3:32 PM

@sam yes, an alternate way of registration would be good, atm we have to re-create what was previously assumed to always be present (when disabling autoscan).

Giorgio Vespucci

09/06/2023, 7:07 AM

Sorry for the delay @Chris Lee, you know, timezones... Should I try to add

SpringAutowireConstructorExtension

or as a replacement for

SpringExtension

? Thanks

Chris Lee

09/06/2023, 12:05 PM

Add them both, to match what auto scan picked up

👍 1

Giorgio Vespucci

09/06/2023, 12:25 PM

Tried with both, but nothing special happened, the configuration looks the same.

Copy code

~~~ Kotest Configuration ~~~
-> Parallelization factor: 10
-> Concurrent specs: null
-> Global concurrent tests: 1
-> Dispatcher affinity: true
-> Coroutine debug probe: false
-> Spec execution order: Lexicographic
-> Default test execution order: Sequential
-> Default test timeout: nullms
-> Default test invocation timeout: nullms
-> Default isolation mode: SingleInstance
-> Global soft assertions: false
-> Write spec failure file: false
-> Fail on ignored tests: false
-> Fail on empty test suite: false
-> Duplicate test name mode: Warn
-> Remove test name whitespace: false
-> Append tags to test names: false
-> Extensions
  - io.kotest.engine.extensions.SystemPropertyTagExtension
  - io.kotest.extensions.spring.SpringAutowireConstructorExtension
  - class io.kotest.engine.config.ApplyConfigFromAbstractProjectConfigKt$applyConfigFromProjectConfig$projectListener$1
  - io.kotest.extensions.spring.SpringTestExtension
  - io.kotest.extensions.spring.SpringAutowireConstructorExtension
  - io.kotest.runner.junit.platform.gradle.GradleClassMethodRegexTestFilter
-> Tags:

Giorgio Vespucci

09/06/2023, 12:25 PM

Did you expect to see something in particular?

Giorgio Vespucci

09/06/2023, 12:27 PM

To be noted that

Copy code

io.kotest.extensions.spring.SpringAutowireConstructorExtension

appears 2 times. Maybe one of the Spring extension is redundant now

Chris Lee

09/06/2023, 12:33 PM

Try tests with auto scan disabled.

Giorgio Vespucci

09/06/2023, 12:42 PM

It just doesn't write any warning, and it's equally slow. The build time is always at least the triple of Kotest < 5.7.0

Giorgio Vespucci

09/06/2023, 12:47 PM

With Kotest 5.6.2

Chris Lee

09/06/2023, 1:05 PM

Ok. Seems like it at least got us past the “no tests found” issue. Not sure where to go w/o more specifics on the setup etc - is it possible to create a minimal reproducer of the issue that can be shared?

Giorgio Vespucci

09/06/2023, 1:07 PM

I should do it, yes. Even to understand if it reproduces with a minimal configuration. It could be also some "conflict" with other libraries we still don't know.

Giorgio Vespucci

09/06/2023, 1:07 PM

I will ping you here as soon as I have something shareable in public GitHub. Thanks for your support so far 👏

👍 1

Giorgio Vespucci

09/06/2023, 1:09 PM

Seems like it at least got us past the “no tests found”

This happened when I switched off the

Copy code

kotest.framework.classpath.scanning.config

and forced the configuration class with

Copy code

kotest.framework.config.fqn

During the latest run I only switched off

Copy code

kotest.framework.classpath.scanning.autoscan

Chris Lee

09/06/2023, 1:10 PM

ah. try with the config scanning turned off as well, forcing the configuration.

Giorgio Vespucci

09/06/2023, 1:11 PM

Trying then with 5.7.1 and

Copy code

kotest.framework.dump.config=true
kotest.framework.classpath.scanning.config.disable=true
kotest.framework.classpath.scanning.autoscan.disable=true
kotest.framework.config.fqn=***.KotestProjectConfig

👍 1

Giorgio Vespucci

09/06/2023, 1:16 PM

Copy code

[INFO] Results:
[INFO] 
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:48 min
[INFO] Finished at: 2023-09-06T15:13:16+02:00
[INFO] ------------------------------------------------------------------------

Copy code

[ERROR] There was an error in the forked process
[ERROR] TestEngine with ID 'kotest' failed to discover tests
[ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There was an error in the forked process
[ERROR] TestEngine with ID 'kotest' failed to discover tests
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:656)
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:282)
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)

Chris Lee

09/06/2023, 1:16 PM

Yea. Need to see if a reproducer can catch this scenario.

Giorgio Vespucci

09/06/2023, 1:16 PM

🫡

sam

09/06/2023, 1:21 PM

I would turn on the debug logging

sam

09/06/2023, 1:21 PM

and upload the full log file

sam

09/06/2023, 1:21 PM

can you set an ENV var with

Copy code

KOTEST_DEBUG=true

sam

09/06/2023, 1:21 PM

and then run the build, that should spam the logs with loads of kotest debugging

Giorgio Vespucci

09/06/2023, 1:22 PM

Yeah, will do it, thanks @sam

Giorgio Vespucci

09/06/2023, 7:59 PM

@sam I’ve just tried my POC at https://github.com/gvespucci/kotest-poc with

KOTEST_DEBUG=true

and it stopped with

Copy code

[ERROR] TestEngine with ID 'kotest' failed to discover tests
[ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There was an error in the forked process

🤔

Giorgio Vespucci

09/08/2023, 12:35 PM

@Chris Lee

Yea. Need to see if a reproducer can catch this scenario.

There is my public POC on GitHub. It's failing as mentioned with the pushed

kotest.properties

. It's failing as well with

-DKOTEST_DEBUG=true

Thank You

Giorgio Vespucci

09/12/2023, 5:02 PM

Opened https://github.com/kotest/kotest/issues/3690

33 Views

Open in Slack

Previous Next

kotlinlang

A modern programming language that makes developers happier.