Does this code look correct? I'm trying to debug on why on recompose the exoplayer doesn't display a...

# compose

[reactormonk]

Does this code look correct? I'm trying to debug on why on recompose the exoplayer doesn't display anymore.

val context = LocalContext.current
    val playerView = remember {
        val layout = LayoutInflater.from(context).inflate(R.layout.video_player_auto, null, false)
        val playerView = layout.findViewById(R.id.playerView) as PlayerView
        playerView.apply {
            player = exoPlayer
        }
    }

    Log.d("VideoPlayer", "View: $playerView")

    AndroidView(
        { playerView },
        Modifier
            .fillMaxHeight()
            .background(Color.Black)
    )

[reactormonk]

Do I have to release the inflated view somehow?

[jw]

Is there a reason you are explicitly remembering the view rather than inflating it within the factory lambda of AndroidView? Are you trying to retain it across changes to the Context?

[reactormonk]

No, no specific reason. Copypasta from somewhere I suspect.

[reactormonk]

... fixed.

[reactormonk]

This seems to work better:

@Composable
fun VideoPlayer(
    exoPlayer: ExoPlayer,
) {
    KeepScreenOn()
    AndroidView(
        {
            val layout = LayoutInflater.from(it).inflate(R.layout.video_player_auto, null, false)
            val playerView = layout.findViewById(R.id.playerView) as PlayerView
            playerView.apply {
                player = exoPlayer
                Log.d("VideoPlayer", "view: $this")
            }
        },
        Modifier
            .fillMaxHeight()
            .background(Color.Black),
        {
            it.player = exoPlayer
        }
    )
}

[reactormonk]

Although I think I should be reusing the exoPlayer instance 🤔

[Vlad]

Is there something wrong remembering a View out of the factory? Sometimes we want to call methods of that View.
For example I might have a WebView running and at some point I will want it to evaluate JS

[jw]

That is what the update callback is for. State reads will cause recomposition and you can do writes to the view state imperatively.