Is there a way to tie this knot? ``` var lifecycleObserver: LifecycleObserver lifecyc...

# android

[reactormonk]

Is there a way to tie this knot?

var lifecycleObserver: LifecycleObserver
        lifecycleObserver = LifecycleEventObserver { _, event ->
            when (event) {
                Lifecycle.Event.ON_START -> player.play()
                Lifecycle.Event.ON_STOP -> player.pause()
                Lifecycle.Event.ON_DESTROY -> {
                    player.release()
                    lifecycleOwner.lifecycle.removeObserver(lifecycleObserver)
                }
                else -> {}
            }
        }
        lifecycleOwner.lifecycle.addObserver(lifecycleObserver)

[Pablichjenkov]

What is the knot 🪢

[reactormonk]

var removeObs = {}
        val lifecycleObserver = LifecycleEventObserver { _, event ->
            when (event) {
                Lifecycle.Event.ON_START -> player.play()
                Lifecycle.Event.ON_STOP -> player.pause()
                Lifecycle.Event.ON_DESTROY -> {
                    player.release()
                    removeObs()
                }
                else -> {}
            }
        }
        removeObs = {lifecycleOwner.lifecycle.removeObserver(lifecycleObserver)}
        lifecycleOwner.lifecycle.addObserver(lifecycleObserver)

[Pablichjenkov]

Lifecycle keeps weak references? Why you need that?
Not duplicating observer instances

[reactormonk]

Aye, works for me then

[Ian Lake]

All observers are automatically removed when the Lifecycle goes through ON_DESTROY, so you don't need to manually remove them at all

[Ian Lake]

That was one of the behavior changes in Lifecycle 2.5: https://developer.android.com/jetpack/androidx/releases/lifecycle#2.5.0

[reactormonk]

Neato, thanks!