Is there a way to model the input to a view model,...

# orbit-mvi

[Jacob Rhoda]

Is there a way to model the input to a view model, such that it’s constant no matter what the state is? Right now I am using a sealed class with an abstract property, but that feels cumbersome.

sealed class FmisCropZonePickerState {
    abstract val input: FmisCropZonePickerInput
    data class Loading(override val input: FmisCropZonePickerInput) : FmisCropZonePickerState()
    data class Error(
        val cause: Throwable,
        override val input: FmisCropZonePickerInput
    ) : FmisCropZonePickerState()

    data class State(
        override val input: FmisCropZonePickerInput,
        val cropZones: List<FmisCropZone>,
        val selectedCropZone: FmisCropZone?
    ) : FmisCropZonePickerState()
}

[twisterrob]

you don't need to make it abstract, but then you lose `data`:

class FmisCropZonePickerInput
class FmisCropZone

sealed class FmisCropZonePickerState(
	val input: FmisCropZonePickerInput
) {
	class Loading(
		input: FmisCropZonePickerInput
	) : FmisCropZonePickerState(input)

	class Error(
		val cause: Throwable,
		input: FmisCropZonePickerInput
	) : FmisCropZonePickerState(input)

	class State(
		input: FmisCropZonePickerInput,
		val cropZones: List<FmisCropZone>,
		val selectedCropZone: FmisCropZone?
	) : FmisCropZonePickerState(input)
}

[twisterrob]

Why do you need the input to be always available?

[Jacob Rhoda]

Hmm, that would work but you loose the benefit of immutable state.

[Jacob Rhoda]

I want the input always available because it’s stuff that realistically never changes. Say, the ID of an item that was selected for a detail view.

[twisterrob]

data doesn't lose immutability, val gives you that.

[twisterrob]

I would store it in a separate "state" in the VM. If you say it never changes, that means it can be even injected in the VM constructor as a val.

[Jacob Rhoda]

Ah, I overlooked the val for the input. But you do lose that convenient copy method, right?

[twisterrob]

yep

[twisterrob]

if you wanna stay with one state and cannot inject it construction time, this could be an option so that the responsibilities don't mix:

class FmisCropZonePickerInput
class FmisCropZone
data class FmisCropZonePickerVMState(
	val input: FmisCropZonePickerInput,
	val state: FmisCropZonePickerState,
)
sealed class FmisCropZonePickerState {
	data object Loading : FmisCropZonePickerState()

	data class Error(
		val cause: Throwable,
	) : FmisCropZonePickerState()

	data class State(
		val cropZones: List<FmisCropZone>,
		val selectedCropZone: FmisCropZone?
	) : FmisCropZonePickerState()
}

[twisterrob]

it might be a classic composition over inheritance thing