https://kotlinlang.org logo
#kontributors
Title
# kontributors
v

Viorel Ștefan Alexandrescu

09/26/2023, 1:57 PM
Hello everyone! K🤘 I'm new around here, but I have decided recently I want to contribute to the Kotlin project in whatever way I can. Right now I would like to pick this issue up as it seems like a neat one to grab. Could someone instruct what am I to do next? More specifically if I just assign it to myself and start working on it. Many thanks in advance 😇
b

bashor

09/26/2023, 11:51 PM
Hi! Nice to hear. Please drop a message in the issue that you working on it (when you start).
v

Viorel Ștefan Alexandrescu

09/27/2023, 9:05 AM
Okay, so no need to assign it to myself, I guess.
b

bashor

09/27/2023, 7:02 PM
Right
v

Viorel Ștefan Alexandrescu

10/03/2023, 3:12 PM
Hey, I've had a look through the sources of the
kotlin
project, but I couldn't quite get my head wrapped around as to what exact implementation is kotlin referencing whenever a
println
is called. My guess right now is that there's a place somewhere in the
wasm
"module" where we map these calls. If I'm wrong, could you point me in the right direction? It's a really intriguing bug 🤔 FYI, I've also searched for the
wasmTest
gradle task, nowhere to be found 😟
@bashor kind reminder on this one 😇
or perhaps could someone lend a couple of hints? many thanks 😃
b

bashor

10/10/2023, 10:55 PM
Did you manage to build the project? If not please take a look here https://github.com/jetBrains/kotlin#building
Gradle tasks:
:wasm.tests:test
— to run compiler tests fro wasm compiler backend
:kotlin-stdlib-wasm-js:check
-- to run stdlib tests for wasm-js target
println
implementation for
wasm-js
is here
v

Viorel Ștefan Alexandrescu

10/12/2023, 7:45 AM
Many thanks for the pointers! Apparently my hunch was right as I had already looked over the file where the
println
implementation lies. I haven't managed to build the project due to some issues with my environment, I'll have a look over that doc and try again.
👍 1
Hey Zalim, I've managed to build the project and run those gradle tasks. Problem is I can't really discern if the bug is reproducible, looking through the tests report output for
kotlin-stdlib-wasm-js:check
, seems to me that the output does in fact show line breaks.
Copy code
test.js.KormaTest.foo[wasm, node] STANDARD_OUT
    0.0313984751701355
    1023450032
    0.029999999329447746
    1022739087
How should I proceed in this case?
FYI, I've ran the test from the issue using
print
instead of
println
and the same occurs (as expected I think, judging from the implementation.
b

bashor

10/13/2023, 8:50 PM
🤷‍♂️ IDK, it’s worth to ask in the issue.
you also can try to reproduce with 1.9.0 or 1.9.0-Beta
v

Viorel Ștefan Alexandrescu

10/15/2023, 2:42 PM
Should I tag someone specifically? If not, sure, I can leave a message with my findings.
b

bashor

10/16/2023, 10:56 AM
Just drop a massage in the issue
👍 1
5 Views