hi, I'm following this article: https://proandroiddev.com/konsist-first-experience-with-the-new-linter-for-kotlin-9153b0e7e2c3 and want to add a simple check first:

Konsist.scopeFromProduction()
   .withModifier(KoModifier.DATA)
   .properties(includeNested = true, includeLocal = true)
   .assertNot {
      it.hasValModifier
   }

one thing is that there's

.classes()

missing after getting the scope (I'll report it to the author), but even after adding it, I'm getting this when running the test:

java.lang.ClassCastException: class org.jetbrains.kotlin.idea.KotlinFileType cannot be cast to class com.intellij.openapi.fileTypes.FileType (org.jetbrains.kotlin.idea.KotlinFileType and com.intellij.openapi.fileTypes.FileType are in unnamed module of loader 'app')
	at com.lemonappdev.konsist.core.util.KotlinFileParser.getKtFile(KotlinFileParser.kt:42)

A full reproducer is here. Am I doing something wrong?

Sorry that was my mistake. I not copied the correct code. Just update it as below

Konsist.scopeFromProduction()
            .classes()
            .withModifier(KoModifier.DATA)
            .properties(includeNested = true, includeLocal = true)
            .assert {
                it.hasValModifier
            }

@PoisonedYouth does the test work fine for you, even after adding

classes()

? do you have a clue why it may not work in my case?

For me it is working after updating as shown above. What is the failure you get?

see the original message in this thread

I'm not sure if this is related to the test. There is a type problem while parsing the input.

@Piotr Krzemiński I have opened your repo (interesting project). Actually heaving branch witch issue helps a lot to speed up things (thx). Your test fails because you have used

assertNot

.assertNot {
      it.hasValModifier
   }

which means you are asserting that these declarations don't have

val

modifier. Just change it to

assert

and test will run

.assert {
      it.hasValModifier
   }

BTW In upcoming release these assertion will be renamed to

assertTrue

and

assertFalse

Thanks for checking the issue, but what was the reason for the ClassCastException?

There are few issues here that have piled up: 1. Test output has almost 6000K lines f code 😅 with

2192

properties 🚀 2. Konsist is not displaying right name for the KoTest test for ki tests

..Assert 'invokeSuspend' was violated (2192 times)...

(will be fixed in next release) 3. It looks like Gradle cuts the logs (they are not full) I am unable to reproduce class cast exception issue after checking out this project - long story short some Kotlin file can't be parsed 🤔 (I guess they may be in some temp/build dir). @Piotr Krzemiński can make this cast problem reproducable on your side, zip entire project and send it my way?

Just tried it on GitHub Actions and there's no ClassCastException: https://github.com/typesafegithub/github-workflows-kt/actions/runs/6415411375/job/17417290875?pr=1006 - will try to prepare a reproducer later

BTW @Piotr Krzemiński I see that in your repo these logs for failing Konsist test are not complete, beginning is missing (not sure why). You should either update your configuration somehow or upload this JUnit report as artifact, to facilitate debugging

github-workflows-kt/library/build/reports/tests/test/index.html

(this artifact contains a complete log for failing test) BTW KoTest support is coming, soon so you will be able to see meaningful method names in crash logs

sounds good, would love to have more details in kotest + I’m surprised Gradle’s build scan doesn’t show anything helpful: https://scans.gradle.com/s/zwtfqkpyeyqj6/tests/task/:library:test/details/io.github.typesafegithub.workflows.ArchitectureTest/all%20data%20classes%20use%20only%20immutable%20fields?top-execution=1

this is the false because you where using

assertNot

instead of

assert

Is it related to Kotest or can you reproduce it with Junit5?

Good catch!

Yes we do track all of this in our backlog. We are currently in the process of transitioning to make the backlog public. but you should be already able to see the ticket in read only. https://lemonappdev.atlassian.net/browse/KON-534

I will have a look on it this weekend.

Great I am curious what you will find here. BTW We are planning to do the next release at the beginning of the week, so it would be good to have a better understanding on this (maybe even a bug fix)

As a first check, the same error does not occur when running the test with Junit5 (independent of running it separately or the complete test file). That is very interesting.

I was able to reproduce this for a brief moment, now issue is gone. I will add a bit more logging , but it looks like project cache was broken. @Piotr Krzemiński I will close this ticket for now. If you will be able to reproduce this issue, then please share a project so we can investigate further.

I got this today as well, both when running the entire test class and a single test

FOr now it looks like a bug in kotest plugin - fortunately cmd works. It may be worth mentioning in the above post - maybe you will provide some valuable information for kotest maintainers.