Is there any plan for SQLDelight 2.0.x patch relea...
# squarelibraries
l
Is there any plan for SQLDelight 2.0.x patch releases? I noticed there's a project to track progress toward your next 2.1 minor release but I'm curious to know if there's anything smaller planned in the meantime. I'm eager to try out some changes in a couple of @griffio's recently completed PRs!
sqldelight 1
a
yes for sure, its high priority for me but been busy with other things
thank you color 2
l
Okay thank you! I'll stay subscribed to the GitHub releases to keep an eye out. Thanks for this amazing library, we enjoy using it every day. 🍻
2
h
Ideally there will be a new release of Kotlinpoet too to fix some local issues with the minus sign.
👍 1
l
Hey @alec! Anything a community member like myself could do to help with a 2.0.x patch release? I'd be willing to organize issues or groom a changelog if it would be a welcome contribution and help get some of this good work released!
sqldelight 🚀
a
helping prep a changelog would be extremely helpful, you could look at the previous release commits for how i do them
🤘🏻 1
my intention is to just review existing PRs before a release, and not existing issues since that would take too much time, and best thing to speed up that PR review process is for them to be green before I go to review. Rekicking CI if necessary, or fixing CI issues, is the absolute best thing for helping speed up the 2.0.x release
h
Do you plan to include sql-psi 0.5.0 too? If so, some changes in code gen would be needed, mostly https://github.com/AlecKazakova/sql-psi/pull/540/files
a
yes for sure sql-psi will be released beforehand
l
Sounds great @alec! I'll take a look at the changelog first as seems like a good place for me to start. If I get through that and am feeling up for more I'll get familiar with how the project has CI setup and inquire about access etc.
a
really appreciate that, thank you
l
@alec I finished a PR to draft a changelog for the next release. I hope it is helpful! https://github.com/cashapp/sqldelight/pull/4781
Hey @alec just checking in on this to make sure it didn't get lost in an old thread. Any feedback on the PR or anything further I can do to help get a patch release rolling?
h
I am obviously not Alec, but your PR is definitely not lost. But one perquisite for a new patch release is the bump of sql-psi, and I am currently working on it. I hope I will finish it this weekend.
sqldelight 1
thank you color 1
l
Are there are any plans for the next SQLDelight release @alec? Would helping draft the release notes again unblock anything? It’s been a while and there are so many great improvements in 2.1.0-SNAPSHOT that we'd love to be able to utilize.
👀 1
h
Personally, I would want to include three things, WASM support, update the IntelliJ plugin (by dropping old support, refactoring the code base), and Gradle project isolation support. Maybe we should create a milestone and discuss the content of the next release.
👍 2
l
That all sounds fantastic. If y'all decided to target those sorts of things for a 2.1.0, what would you think about a 2.0.3 in the meantime? There's several bug fixes y'all have made but AFIAK haven't been included in a formal release yet. I'm tracking 2 in particular that @griffio fixed back in April. https://github.com/cashapp/sqldelight/issues/5172 https://github.com/cashapp/sqldelight/issues/5173
h
That’s also an option
g
There are also numerous issues resolved for Sqlite that fix long outstanding issues e.g https://github.com/cashapp/sqldelight/issues/4877 - prevented 1.x users from upgrading to 2.x SqlDelight https://github.com/cashapp/sqldelight/issues/2799 - fixes Sqlite window function issue from 2022 🕊️
2.0.3
release would help
K 1
thank you color 1
l
Yeah it's coming up on 6 months since the last release, I'm not surprised there's so many fixes pending!
@alec I felt a little out of my element drafting those release notes for 2.0.1, but if you truly found it helpful and it would help unblock a 2.0.3 release I'd do it again–just let me know! Otherwise I'll just wait patiently.
o
Following as I would like to adopt SQLDelight on WASM for my project 🙂 ❤️ sqldelight
1
❤️ 1
l
@alec I saw that sql-psi had a new release a few days ago. Any chance that means we might see a new release for SQLDelight soon?
🎉 1
h
Yes
sqldelight 3
thank you color 3