Hi <@UHAJKUSTU> is there a way to preserve a dialog during orientation change and execute the correc...

# decompose

[Jan]

Hi @Arkadii Ivanov is there a way to preserve a dialog during orientation change and execute the correct lambda?

[Jan]

I have a component with a slot-navigation

[Jan]

I have set persistent to true

[Jan]

My Dialog-Config looks like this:

[Jan]

@Parcelize
    data class DialogConfig(
        val title: StringResource,
        val message: StringResource,
        val onConfirm: () -> Unit = {},
    ) : Parcelable

[Arkadii Ivanov]

You should never have lambdas in your persistent configurations. Configurations are serialized, and you are basically leaking everything that is captured by the lambda.

[Jan]

yes

[Arkadii Ivanov]

Just supply the callback when you instantiate the dialog component

[Jan]

so If I have two different dialogs for different usecase then I have to supply to different callbacks right?

[Arkadii Ivanov]

Yep

[Jan]

thats the only way ... only simple callbacks are working otherwise its leaking due to the lambda bound to a component

[Arkadii Ivanov]

I don't get it. If you pass callbacks via constructor and don't put callbacks in configurations, there should be no leaks.

[Jan]

hard to explain. I thought I could pass different actions via config to my dialog component, but that is obviously not working because If I do so my components are not cleaned up correctly. Aftern rotation I do have 2 components of the same type. Thats because I added an onConfirm lambda via config and the old component is not cleaned up

[Arkadii Ivanov]

You can distinguish your cases when creating the dialog component, based on the configuration

[Arkadii Ivanov]

You can have separate configuration classes for different cases

[Jan]

yes, maybe thats the problem. I thought I could just have one global config and pass lambda-callbacks to it

[Arkadii Ivanov]

Yeah. That's an incorrect approach 🙂

[Jan]

ok, I will try with several configs. In my specific case a dialog config If I really want to delete something and a dialog config If I really want to cancel the current changes

[Arkadii Ivanov]

You can also add an enum to the configuration, and use that for distinguishing. That would be another way.

[Jan]

yep

[Jan]

thanks for help