I think someone might've answered this before but ...

# apollo-kotlin

[Frank Sullivan]

I think someone might've answered this before but I can't find it. Does the cache pay attention to @include directives? I believe I've run into a case where if=false but it's generating a cache miss due to the associated fields being missing.

[mbonnin]

It should, if not it's a bug

[mbonnin]

It's all done here

[Frank Sullivan]

ok thanks I'll try to find out what's going on

[Frank Sullivan]

ok one clue that occurs to me is that our directive is not placed on the problem field itself, but rather on a fragment inclusion e.g.

...myFragment @include(if: $includeMyFragment)

and even though $includeMyFragment is false, there is a field in that fragment that is causing the cache miss. So now I just need to dig in a bit more and figure out why that fragment is included.

[mbonnin]

Interesting. I'm not sure if we have a test for that. If we don't that'd definitely be a good one to have

[Frank Sullivan]

Yeah I think it might need a condition check in CacheBatchReader.collect()

[mbonnin]

I'm in the middle of something but will double check in a bit

[mbonnin]

I can reproduce with https://github.com/apollographql/apollo-kotlin/compare/main...add-test-for-fragment-include, looking into it...

[mbonnin]

Fix there: https://github.com/apollographql/apollo-kotlin/pull/5296

[mbonnin]

In the meantime you can put @include on individual fields instead. Not perfect but it's a path forward

[Frank Sullivan]

awesome, thank you!