A modern programming language that makes developers happier.

kotlinlang

Hi there :wave:

My name is Marko Savic and I am Sr. Android Engineer at New York Times :slightly_smiling_face:


I have integrated `Paging3` library into our Article comments UI -  with Jetpack Compose
```collectAsLazyPagingItems()```
 support and we also have implemented `jetpack compose navigation`  ( from comments page to comments thread page. )

Issue that now we have is that when animation navigation happens it triggers API call couple of times during animation and I don't know why that happens!!! :cry:

Issue is similar to this one: <https://stackoverflow.com/questions/71410790/paging-3-list-auto-refresh-on-navigation-back-in-jetpack-compose-navigation>
and I have tried saving the instance of Pager but that didn't help :cry:

Of course I am using:
```flow.cachedIn(viewModelScope)```
and Paging3Version is `3.2.0`

Btw, I didn't have a luck to find any complex example like in my case where you have Paging3 + JetpackCompose + navigation
Also we have Tabs there but it's another part of story.

Does anyone has experience around this problem? :thank-you-color:

:bow:

&gt;  it triggers APl call couple of times during animation
&gt; 
This sounds like you are doing something as part of composition (as it is expected that your screen recomposes multiple times during an animation), but you shouldn't ever be triggering anything API call related as part of composition or as part of an Effect really - Paging automatically refreshed when your PagingSource invalidates itself

We discussed this on Twitter a while back: <https://twitter.com/ianhlake/status/1692754799387640043|https://twitter.com/ianhlake/status/1692754799387640043>

I appreciate <@UJBPFB3SN> I will take a look

paging3_diagram.png

Hey <@UJBPFB3SN> :wave:

I appreciate your help on this one but I still didn't find working solution for my problem. I tried 3 or 4 different approach but result is still the same - during animation I am getting multiple API call's for the same route (and params).

Because of that I decided to write an diagram so it would be easier for your to understand the situation.

Result of this code is this LOG:

```&lt;--- ANIMTION start ---&gt;
enterTransition Blue
exitTransition Red
enterTransition Blue
exitTransition Red
&lt;--- ANIMTION end ---&gt;

&lt;--- UI load ---&gt;
Render Blue

&lt;--- ANIMTION start ---&gt;
enterTransition Blue
exitTransition Red
&lt;--- ANIMTION end ---&gt;

&lt;--- UI load ---&gt;
Render Red

&lt;--- API CALL ---&gt;
load load load

&lt;--- UI load ---&gt;
Render Blue

&lt;--- API CALL ---&gt;
load load load```
Did ViewModel clears cache somehow?
Does load method calls for not reason?

Thanks! :pray: :bow:

Yeah, your ViewModel is wrong: you're creating a new Pager and a new Flow every composition. Store that Flow as a variable in your ViewModel

I.e., it should be a `val`, not a `fun get`

oh that's the problem, thanks! let me try

Omg it's woring <@UJBPFB3SN> such a small thing :disappointed:

We actually specifically updated the docs to call this out just a week and a half ago (which will update on the next Paging release): <https://android-review.googlesource.com/c/platform/frameworks/support/+/2788440>