org.http4k.connect.amazon.cognito.CognitoExtension...
# http4kd
dmcg
10/25/2023, 9:17 AMorg.http4k.connect.amazon.cognito.CognitoExtensionsKt#confirmForgotPassword is generated code? Is there any way to have its
ClientMetadataemptyMap()a
Andrew O'Hara
10/25/2023, 2:19 PMYes, default parameters in the generated extension functions would be very nice. The generator seems to ignore the defaults of the request class it's based on.
d
dmcg
10/25/2023, 3:40 PMAh, so yes, and then no 😉
a
Andrew O'Hara
10/25/2023, 3:50 PMI don't actually know whether the defaults can be added or not. I'll let @dave answer that.
d
dave
10/25/2023, 3:51 PMit's tricky - you'd need to adjust the code KSP generator
dave
10/25/2023, 3:51 PMI presume you might have access to the default values, but I'm not sure.
dave
10/25/2023, 3:53 PMFeel free to have a play - you need to edit the code around: https://github.com/http4k/http4k-connect/blob/da3eed9216c34d82f6ebbbd1e5904e483025[…]/kotlin/org/http4k/connect/plugin/Http4kConnectActionVisitor.kt
dave
10/25/2023, 3:54 PM(I know that it's annoying to not have the defaults generated)
dave
10/26/2023, 7:58 PM@dmcg just for you - we now generate default values when there is a default collection present. I wasn't clever enough with the KSP API to make it work for everything... https://github.com/http4k/http4k-connect/blob/master/CHANGELOG.md#changelog
🙏 2
d
dmcg
10/27/2023, 1:21 PMFair exchange is no robbery https://github.com/http4k/http4k-connect/pull/311
2 Views