Hello, we're using `ProcessLifecycleOwner.get().lifecycle.coroutineScope` injected with Dagger in lo...

# android

[galex]

Hello, we're using ProcessLifecycleOwner.get().lifecycle.coroutineScope injected with Dagger in lots of ViewModels to perform network requests that are to be done no matter what happens to the lifecycle of the ViewModel.
I am purposely trying to prove that this is a really bad practice, so with the help of LeakCanary I am running code that looks like this:

processScope.launch {
    delay(10 * 60 * 1000)
    doSomeNetworkRequest(someParameter)
}

But this doesn't trigger a leak, apparently.
What am I missing?

[Eduardo Dantas]

Apparently the solution you guys are using is what is recommended by Google

https://medium.com/androiddevelopers/coroutines-patterns-for-work-that-shouldnt-be-cancelled-e26c40f142ad

[Eduardo Dantas]

My understanding is that you would only get something to leak if you have permanent references to UI or ViewModel long after they have been cleaned up

[galex]

Thanks! I think we do catch a leak but I don't manage to reproduce it

[gildor]

It will leak only if doSomeNetworkRequest touches Activity/Views. if not, there is no reason for Lambda to keep reference to Activity/Context, so it will not cause leak automatically, Kotlin compiles lambda differently, depending on case