https://kotlinlang.org logo
Channels
Powered by
#konsist
Title
# konsist
p

Piotr Krzemiński

10/31/2023, 2:59 PM
Konsist causing some trouble when bumping to Kotlin 1.9.20: fix(deps): update kotlin monorepo to v1.9.20 - have you encountered this issue?
i

igor.wojda

11/04/2023, 5:48 PM
I will investigate
👍 1
@Piotr Krzemiński It started working for me after adding 
testImplementation("org.jetbrains.kotlin:kotlin-compiler:1.9.20")
dependency. Branch 
renovate/kotlin-monorepo branch
File" 
library/build.gradle.kts
Please verify if this work for you
It looks like 
kotlin:kotlin-compiler
dependency is not added correctly to the test source set, however it is provided by Konsist. This issue is under investigation https://lemonappdev.atlassian.net/browse/KON-576 I am open for ideas here.
@Piotr Krzemiński I suspect this is a Kotlin regression bug. Here is the Kotlin ticket https://youtrack.jetbrains.com/issue/KT-63187/Upgrade-from-1.9.10-to-1.9.20-breaks-the-project
p

Piotr Krzemiński

11/05/2023, 6:38 PM
Ah, with the explicit dependency it works, but now my tests using 
com.github.tschuchortdev:kotlin-compile-testing:1.5.0
fail which is a separate issue. Looks like depending on libraries that depend on compiler's (internal?) API is problematic
I'll try to figure it out and come back to you
❤️ 1
I ended up with such change prior to bumping Kotlin to 1.9.20: chore(lib): switch from com.github.tschuchortdev:kotlin-compile-testing to dev.zacsweers.kctfork. In short, some other library depending on kotlin-compiler was messing something up, so I decided to switch to its fork that is better maintained and supports newer Kotlin versions. I still had to use the newest version of kotlin-compiler (
testImplementation(kotlin("compiler"))
). After this change, bumping Kotlin to 1.9.20 was simple
i

igor.wojda

11/06/2023, 1:30 PM
thx for the info. Can you drop a comment on the Kotlin ticket on what was core issue - perhaps they will be able to improve error handling on this int the future https://youtrack.jetbrains.com/issue/KT-63187/Upgrade-from-1.9.10-to-1.9.20-breaks-the-project
Added comment to Kotlin ticket. I think we can consider this issue closed. BTW this was an interesting one 🤓
p

Piotr Krzemiński

11/07/2023, 9:27 AM
thanks, I still don't feel like we got to the very bottom of the problem (I haven't checked what version of kotlin-compiler the other library ingests), but thanks anyway for your assistance 🙂 I think the culprit here is unstable compiler's API, changing from release to release
i

igor.wojda

11/07/2023, 9:28 AM
I have asked Kotlin team "if there is anything we can do about this issue to handle these mis matched dependencies in the future?" Let's observe this one
👍 1
BTW I am finding this lib quite interesting. I wonder what is you exact use case for it?
p

Piotr Krzemiński

11/07/2023, 9:30 AM
thanks, please see the landing page in the docs, I think we've nailed it there: https://typesafegithub.github.io/github-workflows-kt/ - happy to clarify further 🙂
👍 1
+ please feel welcome to join #github-workflows-kt 🙂
Powered by