Any idea why my MP project targetting JS and Android fails to compile on JS with `e: kotlin.NotImple...

# multiplatform

[Jan]

Any idea why my MP project targetting JS and Android fails to compile on JS with e: kotlin.NotImplementedError: Generation of stubs for class org.jetbrains.kotlin.ir.symbols.impl.IrValueParameterSymbolImpl is not supported yet but on Android it works completely fine. Newest Compose, Kotlin, Gradle and AGP version. Link: https://github.com/jan-tennert/EinkaufszettelMP

[Jan]

Note: It started to fail after this commit: https://github.com/jan-tennert/EinkaufszettelNext/commit/64297202341aa62b74bf7dfc513b8675e3585dc2

[Pablichjenkov]

You can ask in #compose-web

[Jan]

I mean it isn't necessarily a compose issue, it compiled before this commit (and it already included compose)

[Pablichjenkov]

Let me see

[Pablichjenkov]

Try commenting out one dependency at a time.

[Pablichjenkov]

Is either koin or voyager

[Pablichjenkov]

I think somebody was having some issues with voyager and kotlin 1.9.20

[Jan]

Okay its koin-compose 🤔

[Jan]

I'll create an issue

[Pablichjenkov]

I see you added a specific koin artifact for Android, don't you miss the counter side in JS?

[Jan]

The koin-android dependency just includes things to add the android context etc. nothing you need on other targets

[Pablichjenkov]

I see you are correct

[Pablichjenkov]

JS is just commonMain

[Jan]

okay nvm can't repoduce it in another project. Also just commenting the content of the method Content in this file: https://github.com/jan-tennert/EinkaufszettelNext/blob/master/composeApp/src/commo[…]otlin/io/github/jan/einkaufszettel/ui/screen/auth/AuthScreen.kt
Also fixes the compilation error

[Jan]

(the dependency is still there)

[Jan]

Okay seems to be exactly this line: https://github.com/jan-tennert/EinkaufszettelNext/blob/19100baa176bf78d6f1e898bfb1[…]otlin/io/github/jan/einkaufszettel/ui/screen/auth/AuthScreen.kt
I'll check this out

[Pablichjenkov]

Interesting, cmd + click to see what's inside

[Pablichjenkov]

Is that a Composable extension function on ?

[Jan]

It's my own dependency, it's this and/or the implementation (for JS)

[Pablichjenkov]

Yeah is a Composable extension function, I believe JS compiler was still struggling with this.

[Pablichjenkov]

If I am not mistaken there are some open issues for these

[Pablichjenkov]

Try changing your design.

[Pablichjenkov]

Remove the Composable in the extension function and just call a regular Composable function that internally call the extension function

[Jan]

I'm confused, so the ComposeAuth.rememberLoginWithGoogle shouldn't be an extension function?

[Pablichjenkov]

The Composable annotation on it

[Pablichjenkov]

Try without it.

[Jan]

yea but the implementation does need to be in a composable, or doesn't that matter?

[Jan]

the implementation (in this case JS) calls defaultLoginBehavior which itself uses a LaunchedEffect

[Pablichjenkov]

Try like this see if it works

actual fun ComposeAuth.rememberLoginWithGoogle(onResult: (NativeSignInResult) -> Unit, fallback: suspend () -> Unit): NativeSignInState = defaultLoginBehavior(fallback)

@Composable 
actual rememberLoginWithGoogleWrap(onResult: (NativeSignInResult) -> Unit, fallback: suspend () -> Unit) {
    rememberLoginWithGoogle(fallback)
}

// commonMain
@Composable 
expect rememberLoginWithGoogleWrap(onResult: (NativeSignInResult) -> Unit, fallback: suspend () -> Unit)

[Jan]

so I just remove the composable annotation on rememberLoginWithGoogle ?

[Pablichjenkov]

Yes

[Jan]

also on the common rememberLoginWithGoogle or just the JS actual one?

[Pablichjenkov]

You have to do it in commonMain or the compiler will complain

[Jan]

okay so both

[Jan]

Okay publishing it to maven local rn, but shouldn't it generally complain because rememberLoginWithGoogle (which is not a composable) calls a composable function?

[Pablichjenkov]

Yes that is right, let me read the code again

[Pablichjenkov]

I think you will have to call defaultLoginBehavior directly

[Jan]

hmm that is definitly inconvenient

[Pablichjenkov]

It is yes

[Pablichjenkov]

Not sure if making it inline could help, But still you can call inline from Composab;e but not the other way

[Jan]

yea thought about that too but that doesn't sound like the right solution

[Jan]

I'll try that and see if it helps

[Pablichjenkov]

I know, It is hard to mix the JS target with other target because this type of things.

[Pablichjenkov]

You can’t use all the kotlin goodies

[Jan]

probably will do a workaround for my project for now, I don't know how I could fix that in the dependency so that it doesn't break other things

[Pablichjenkov]

I actually checked and I have similar code in some of my projects and it compiles. Uses an extension lambda

[Pablichjenkov]

Can you check the library you are using, what kotlin version it was compiled with. I am thinking of some binary incompatibility or something

[Pablichjenkov]

val TopBarComponentView: @Composable TopBarComponent<TopBarComponentViewModel>.(
        modifier: Modifier,
        activeChildComponent: Component
    ) -> Unit = { modifier, activeChildComponent -> ... }

That works for me an is basically a lambda extension function. Maybe a lambda works for you
The only thing I don't see is the expect/actual symbol. Hopefully has nothing to do with it

[Jan]

Hey, so both the library and my app use Kotlin 1.9.20 and Compose 1.5.10, and for your solution: I can try that but that would obviously be a breaking change

[Pablichjenkov]

Ah I see 👍