After Zipline Release 1.3.0, My previous working p...

# squarelibraries

[Shabinder Singh]

After Zipline Release 1.3.0,
My previous working plugins are now crashing, with following:
app.cash.zipline.QuickJsException: stack overflow

My executor thread is of 8mb as suggested in changelog, also tried with higher limit,
is there any other change needed from my client side ?

Context: I deploy a plugin system, hence code can be complex sometimes, involving serializations and network requests and so on.

[jessewilson]

I hate this particular error because we don’t have good metrics on what our stack size usage is, so it’s difficult to gauge what number is appropriate

[jessewilson]

Our configuration is here:
https://github.com/cashapp/redwood/blob/trunk/redwood-treehouse-host/src/androidMa[…]otlin/app/cash/redwood/treehouse/AndroidTreehouseDispatchers.kt

[jessewilson]

https://github.com/cashapp/redwood/blob/trunk/redwood-treehouse-host/src/iosMain/kotlin/app/cash/redwood/treehouse/IosTreehouseDispatchers.kt

[Shabinder Singh]

I have tried going till 64 mb, still get this,
Zipline is internally setting 6mb from 1.30 onwards, is that the cause ?

[jessewilson]

oooh that could be it

[jessewilson]

You can configure this

[jessewilson]

zipline.quickJs.maxStackSize = XXX

[Shabinder Singh]

I did and remove that as we had prior to 1.30,
and it worked again, but one particular service is crashing with following trace.

https://kotlinlang.slack.com/archives/C5HT9AL7Q/p1699445509310039?thread_ts=1691432897.694099&cid=C5HT9AL7Q

and I am not able to make any sense of it, I put some logs, and my functions from service executes till last line and then zipline crashes and host never gets the returned item.

[Shabinder Singh]

I have been brewing over this for many hours now do hit and trial but still at a dead end...
if you can point in correct direction, it will help a lot.