https://kotlinlang.org logo
#github-workflows-kt
Title
# github-workflows-kt
p

Piotr Krzemiński

11/10/2023, 6:27 AM
github workflows kt v1.5.0 released!
🎉 2
so yeah, I encourage you to migrate to the new approach and share your thoughts (together with PRs with a successful migration) on this channel 🙂
happy to help in case of troubles
v

Vampire

11/10/2023, 7:45 AM
"biding generation" => "binding generation"
1
gratitude thank you 1
To be honest, from reading the docs I don't like it too much. Of course I understand the intention to need less frequent releases and so on which is also better for consumers with auto-update tools, but • It increases execution time • You cannot use different major versions in different places if I got it right • Why that extra unrunnable workflow? Why not at least giving the actions to the generate call as parameter? • Current IDE problems with
@Import
Maybe generate to
.github/actions/generated
instead or make it configurable if it isn't.
p

Piotr Krzemiński

11/10/2023, 8:04 AM
> It increases execution time in the current implementation, yes. It's the cost of the tradeoff. We can think how to improve it, e.g. keep generated bindings in the repo and have a cheap method of checking if the bindings need to be regenerated
> You cannot use different major versions in different places if I got it right for now yes, it's my intended simplification. I didn't want to implement it up front because I wonder if there's any demand for using multiple major versions. If you do have such real-life scenario, let me know. I have some ideas how to implement it
> Why that extra unrunnable workflow? Why not at least giving the actions to the generate call as parameter? To support dependency update bots like Dependabot or Renovate. We can consider an alternative API like you suggest, something inside
generate-action-bindings.main.kts
, for those who don't care about the bots
> Current IDE problems with
@Import
🤷 something has to happen first: either they fix the problems, or someone starts using this feature that will increase the priority of fixing the issues 😄 We can consider waiting longer until it's fixed, but keep in mind that waiting longer impacts mostly me as I need to keep the bundled bindings up-to-date. In a month my life will change to an extent that I may not be able to do it regularly, so this change in the approach is a part of adjusting to the new circumstances. I keep track of the tickets on the Kotlin side in https://github.com/typesafegithub/github-workflows-kt/issues/1090 - I encourage you to push JB to fix it sooner
great feedback, thank you 🙇 will ticket all these issues soon
v

Vampire

11/10/2023, 10:16 AM
keep generated bindings in the repo
Don't like that either, generated things have nothing to do in the repo that generates them imho. 🙂 Same for the yaml files, but that's simply not possible right now without the native integration we hope for.
If you do have such real-life scenario
Not right now personally, but I think there are for sure cases where you might need it. 🙂
for those who don't care about the bots
They should at least still notify you about updates I think, as they will find the old versions in the generated yaml workflow files.
I encourage you to push JB to fix it sooner
Unfortunately, nothing I can do besides upvoting which I already did.
p

Piotr Krzemiński

11/11/2023, 5:28 AM
@LeoColman would you be open to trying out the new approach? Open to your feedback as well!
l

LeoColman

11/11/2023, 1:59 PM
Absolutely! I didn't read your convo tho. Let me know what you want to try and I'll do it pronto 😄
p

Piotr Krzemiński

11/11/2023, 2:30 PM
See the release notes :)
👍 1
K 1
github workflows kt 1
2 Views