A modern programming language that makes developers happier.

kotlinlang

Anyone know why classic frontend <https://github.com/rickclephas/KMP-NativeCoroutines/blob/4bc8e874edd19990d38423fd126ebc9d468522de/kmp-nativecoroutines-compiler/src/test/kotlin/com/rickclephas/kmp/nativecoroutines/compiler/runners/AbstractDiagnosticsTest.kt|diagnostics tests> are no longer working in 2.0.0-Beta1? Some kind of new config that I am missing?

All tests are failing in 2.0.0-Beta1. None of the diagnostics are present in the output.

image.png

We still use them in master, so nothing wasn't broken intentionally
Some stack trace maybe helpful

There recently was <https://github.com/JetBrains/kotlin/commit/118324445530a9382a1cc8542ae7e7d3c72da72c|change> about handling klibs for classic frontend facade
It may be relevant

Untitled

Yeah I noticed similar tests in master (that haven’t changed much since I based my tests on them). A stack trace in case it points to any obvious issues:

Found another <https://github.com/JetBrains/kotlin/commit/8f03eb931467f375d1428c5b73196bf015892f54|change> related to DiagnosticsNativeTests and stdlib.
Not sure why it’s needed/what it’s supposed to do, but <https://github.com/rickclephas/KMP-NativeCoroutines/commit/94566281f81eae19f58f2ee94f4e3047b7ddd3c6|adding> that `LibraryProvider` and the `WITH_STDLIB` directive solved it.

FYI the stack trace mentions a `NoSuchElementException` at `ClassicFrontendFacade.kt:554`, not sure about the line number (554 doesn’t exist),
but it seems that with <https://github.com/JetBrains/kotlin/commit/3aa6c9e74d11a13bc2ed1e912772ed4c2891a0da#diff-d2bf1f5cfdaa1a8a9a98751120174e8a778fa7ba03b12a3d6c48405566dcda3bR399|this> change stdlib is now required for all tests using the `ClassicFrontendFacade`.

Not really an issue to include stdlib, though for the native environment that requires `kotlin.internal.native.test.nativeHome` to be set (which I am currently getting from `NativeCompilerDownloader`).
I guess that is to be expected as I am using the *internal* test framework :grin:.

Yeah, native is much more internal than other internals

<@U01EMBJSZHA> Hi, yes, you found a recent fix of ClassicFrontendFacade to use native stdlib instead of common stdlib. Without fix, native diagnostic test without `// WITH_STDLIB` used common stdlib and did not see
`    public final /*synthesized*/ val entries: kotlin.enums.EnumEntries<T>` in enums, which are unique to native stdlib.
It can be seen in lines like <https://github.com/JetBrains/kotlin/commit/8f03eb931467f375d1428c5b73196bf015892f54#diff-754bc0f20ca136f2868b92a96101339637ad779f805581b49edc88f8a9461468R53>

So, `WITH_STDLIB` directive was permanently set, and native stdlib proper lookup now is needed for all native tests

Before fix, common stdlib was used, which did not have `enumEntries` property (I guess this <https://github.com/JetBrains/kotlin/blob/1564f2c549bbdff361c02f71aa128e06274336ce/core/builtins/native/kotlin/Enum.kt#L13>)
and now native stdlib is used, which has the property <https://github.com/JetBrains/kotlin/blob/64fd4ac510f56f1d5480a1631849c1852a689d5a/kotlin-native/runtime/src/main/kotlin/kotlin/Enum.kt#L44>