I have a method that is totally redundant to call ...

# intellij-tricks

[Manuel Dossinger]

I have a method that is totally redundant to call multiple times. Think

doResetWithValue(5)
doResetWithValue(5)

but with less obvious names.
Is there a way to get an inspection warn me about this pattern?
Similar to "redundant assignment" but with my method.

[Raimund Klein]

That’s a special case of Duplicated code. https://www.jetbrains.com/help/idea/analyzing-duplicates.html#configure-inspection

[xoangon]

You can also use the "Replace structurally" option and then convert that rule into an inspection

[Manuel Dossinger]

@Raimund Klein now that you said it, actually the example should read something like

doResetWithValue(7)
doResetWithValue(5)

(the arguments are different, but the second invocation trumps the first one rendering it useless)

[Manuel Dossinger]

@xoangon I tried the strucutally replace option, but was not able to get it to match these two subsequent method invocations. I'd be happy about a hint there 🙂

[xoangon]

I need more information. May those repeated invocations happen in the same scope (say, for example, the same method)? Are those invocations always consecutive?

[Manuel Dossinger]

No, not consecutive. Same method/scope yes, but not in different branches. I thought it would be easier to start with consecutive invocations.

So the following would be ok and should not be caught by the inspection:

if(condition) doResetWithValue(5) else doResetWithValue(7)