Hi guys, I am reading this <viewmodel> document an...

# compose-android

[KotlinLeaner]

Hi guys, I am reading this viewmodel document and it says You should never pass down ViewModel instances to other composable. Is there any strong recommendation for this? Can you please tell me which is better and why?

[KotlinLeaner]

1. I like this way because of document

val myModule = module {
    viewModel { MyViewModel() } 
}

------

@Composable
fun MyComposable(viewModel: MyViewModel = koinViewModel()) {
}

[KotlinLeaner]

2. My team saying that we need to use second approach something like this way. By setting the scope View Model like the sample below 👇

val myModule = module {
    viewModel { MyViewModel(get()) } scoped(viewModelScope)
}

------

@Composable
fun MyComposable() {
    val myViewModel: MyViewModel = viewModel()
}

[Chrimaeon]

this is fine, you should just not pass it on to composables called from your MyComposable for the same reason as https://kotlinlang.slack.com/archives/C04TPPEQKEJ/p1700385922837689

[KotlinLeaner]

Thanks Christian, I'll take a look now.

[Ankit Kumar]

I reason I can recall
if you pass viewmodel/mutableState down the composable, then it can increase recomposition

since compose will treat viewmodel or mutable state as unstable, so it will recompose for each call