I'm having a super weird bug again with integrated tests, `onClick` is sometimes not called on a nod...

# compose

[vide]

I'm having a super weird bug again with integrated tests, onClick is sometimes not called on a node, (seemingly) because the node is not displayed yet. However the test tag still exists. 🧵

[vide]

log looks like this

W  clicking...
 W  interaction: androidx.compose.foundation.interaction.PressInteraction$Press@b0db5ac
 W  interaction: androidx.compose.foundation.interaction.PressInteraction$Release@e1bea7b
    [missing an onClick log here]
 W  ...clicked

and the code just looks like this

.clickable(
    indication = null,
    interactionSource = interactionSource,
    onClick = {
        logger.warn("onClick")
        // other stuff
    }
)

[vide]

what could be the cause of this? if I add an aritificial delay of say 500ms before clicking, it works normally

[theapache64]

whats ur compose version ?

[vide]

1.6.0-alpha07

[vide]

Another flaky test I have doesn't seem to sometimes even get an interaction event.

[theapache64]

tried with 1.6.0-beta01 ? i usually bump to latest version as a first step of debugging 😄

[vide]

no, there's another issue preventing upgrading at this point 😐

[vide]

I guess I could still try

[theapache64]

there’s another issue preventing upgrading at this point

ooops.. which one ?

[vide]

https://issuetracker.google.com/issues/311925526

[vide]

And it's quite hard to be sure of when it's working, as said this is flaky and not failing every time. It fails about 10% of test runs

[theapache64]

ohh 😮

[vide]

hm, I think I know why it's happening

[vide]

the component doesn't seem to be displayed yet when it's trying to click it

[vide]

it's weird because I even try calling composeTestRule.waitForIdle() before trying to click, I would assume it would only continue after everything in the current recomposition is displayed etc

[theapache64]

aah.. wait till full-draw should work then

[vide]

so when it fails to click, assertIsDisplayed() also fails the assert

[theapache64]

hmm.. wait until displayed is needed here i guess

[theapache64]

.

[theapache64]

device.wait(
    Until.hasObject(findBy()),
    timeout.inWholeMilliseconds
)

should do the magic

[vide]

uhh, what test apis are these?

[vide]

this has actually been discussed before: https://kotlinlang.slack.com/archives/CJLTWPH7S/p1695761272289639

[vide]

I wonder what the fundamental reason here is that
1. The component isn't displayed yet even though the test tag is in the tree
2. The click event doesn't go through when it's not displayed. Does the test runner try to actually "click" some coordinates on the screen instead of somehow delivering the event directly?

[vide]

isPlaced=true,
isAttached=true,
boundsInWindow=Rect.fromLTRB(0.0, 0.0, 0.0, 0.0)

🤔

[Zach Klippenstein (he/him) [MOD]]

There are a few places where zero-size nodes are treated as non-existent, since they are effectively hidden from the users perspective. Seems like you might be hitting that?

[vide]

Do you have any idea why any elements would be zero-sized? I had the impression the test framework waits for the UI to be idle? I'm seeing this on nodes which definitely have a non-zero size defined

[vide]

Reviewing some other flaky tests, it also seems like waitUntilNodeCount also sometimes returns when the node isn't even attached yet 😅

[Zach Klippenstein (he/him) [MOD]]

Sounds like a bug on our end