Hey guys, using `koin-annotations` in KMP project,...

# koin

[matsem]

Hey guys, using koin-annotations in KMP project, can I include expect/actual class module inside another module? The following setup fails during build with: Expected class PersistencePlatformModule does not have default constructor and I’m not sure if there’s an issue with my ksp setup, or there’s just no support for these things right now:

// src/commonMain/
@Module([PersistencePlatformModule::class])
class PersistenceModule { ... }

@Module
expect class PersistencePlatformModule { 
    expect fun platformSpecificDependency() = ...
}

// src/androidMain/
@Module
actual class PersistencePlatformModule(androidContext: Context) { ... }

// src/iosMain/
@Module
actual class PersistencePlatformModule() { ... }

[Christopher Mederos]

I will mention that a few KMP Koin projects create a koin initialize function that accepts a module as a parameter. Each platform calls the function to start koin and passes their platform specific dependencies there.

fun initKoin(platformModule: Module = module { }, appDeclaration: KoinAppDeclaration = { }) =
    startKoin {
        appDeclaration()
        modules(commonModule(), platformModule)
    }

[Christopher Mederos]

Otherwise, I have declared an expected koin module as a function instead of a class.

// commonMain
expect fun platformModule() : Module

// iosMain
actual fun platformModule() = module {
    single<HttpClientEngine> { Darwin.create() }
}

// androidMain
actual fun platformModule() = module {
    // android implementation of http client for ktor
    single<HttpClientEngine> { Android.create() }
    single<HttpClientConfig<AndroidEngineConfig>> { HttpClientConfig() }
}

[Christopher Mederos]

I'd say the expect style is generally cleaner. However, if you need to initialize a Kotlin class with some kind of provider that is only available in iOS, then you can add pass it from iOS using additional parameters in the initKoin() function

[matsem]

Yeah, modules as expected function is how we do it without annotations and it just works flawlessly, however I was interested in the annotations approach, because we want to get that compile time checks working. If you mix up annotations and plain old modules as functions, the compile time check will break.

[burnoo]

For using actual/expect classes you need to add constructor explicitly. Also you need to pass context as function parameter.

// src/commonMain/
@Module([PersistencePlatformModule::class])
class PersistenceModule() { ... }

@Module
expect class PersistencePlatformModule() { }

// src/androidMain/
@Module
actual class PersistencePlatformModule actual constructor() {
    fun someDependency(androidContext: Context) : SomeDependency(androidContext)
}

// src/iosMain/
@Module
actual class PersistencePlatformModule actual constructor() { ... }

[matsem]

So I gave this a try… It turns out this does not work.

You must define your dependency in commonMain’s PersistencePlatformModule as expected function in order for Koin to pick it up, but this cannot be done when actual implementations have different function signature (androidMain has Context parameter and iosMain has no parameter).

You could omit the expected function from PersistencePlatformModule and just define dependencies as classic functions in each actual class implementation like in example you provided, but Koin will then crash at runtime with NoBeanDefFoundException because it apparently does not know about the dependency when it is not commonMain module.

[arnaud.giuliani]

it's the case of expect module right?

[arnaud.giuliani]

seems the compiler doesn't scan the actual one 🤔

[arnaud.giuliani]

can you raise an issue on koin-annotations project?

[matsem]

will do!

[matsem]

https://github.com/InsertKoinIO/koin-annotations/issues/105

[Nacho Ruiz Martin]

Hey 👋
Is there any workaround for this? None of the workarounds proposed in the GH issue work for me.

[arnaud.giuliani]

Workaround are hard to go beyond generated code. I will work on it soon, else it can be developed by someone else

[Nacho Ruiz Martin]

Thanks, Arnaud. I can take a look at it, else I'll wait 😊.