https://kotlinlang.org logo
#compose-android
Title
# compose-android
c

Colton Idle

11/21/2023, 2:38 PM
I'm trying to fork accompanist webview into my codebase by just copy pasta, but I can't find the import of
com.google.accompanist.web.LoadingState.Finished
or
Loading
. Using github code search, it just looks like that class doesn't exist. Am I missing something basic?
s

Stylianos Gakis

11/21/2023, 2:39 PM
I’ve done the same forking, and I got this here https://github.com/HedvigInsurance/android/blob/5f1f762af6f5af12cc93946f7113bc4c9c[…]ew/src/main/kotlin/com/hedvig/android/composewebview/WebView.kt which I am certain I did not write myself 😄 It may just be somewhere nested in the code you are copying over
Maybe do a search for the same comments (Which I also did not write myself) and you’ll find the right thing
c

Colton Idle

11/21/2023, 2:43 PM
Why did that not show up in github code search? 😭 You're right. it was right there. thanks for the quick look Stylianos
😉 1
here i thought that cs.github.com was good lol
s

Stylianos Gakis

11/21/2023, 2:48 PM
Does that even index things in GitHub though?
c

Colton Idle

11/21/2023, 2:50 PM
i thought it did? it used to give you a warning if a codebase wasn't indexed IIRC
blob shrug 1
s

Stylianos Gakis

11/21/2023, 2:51 PM
Oh you wrote cs.github.com. I read cs.android.com. In fact I think my brain stopped at
cs.
and instantly assumed that’s what you were talking about 😄
👍 1
same 1
c

Colton Idle

11/21/2023, 5:55 PM
wonder if anyone is maintaining a webview fork 😅
s

Stylianos Gakis

11/21/2023, 6:41 PM
You copy the code -> it works. Sounds maintained enough to me 😅
😄 2
3 Views