https://kotlinlang.org logo
#apollo-kotlin
Title
# apollo-kotlin
g

goku

11/24/2023, 2:21 AM
Hello, is there a convenient way to customize codegen template (without manually going over the classes and modifying them)? Trying to add
@JVMOverloads
to data class constructors. Using v3.
I found this but doesn’t work in following cases: • if the Operation doesn’t have optional arguments • for fragments • for Inputs I need this option to provide backward compatibility. Ex: This change is binary incompatible. Precompiled code that calls
UserFragment("John")
will break when it is transitively upgraded to v2.
Copy code
// v1
data class UserFragment(
  val name: String,
)
Copy code
// v2
data class UserFragment(
  val name: String,
  val age: Int,
)
b

bod

11/24/2023, 5:32 AM
Hi! Compiler hooks may help for this. They are experimental and not well documented but you can find a few examples here: https://github.com/apollographql/apollo-kotlin/blob/main/tests/compiler-hooks/build.gradle.kts#L91 (Note: to use them you need to use the
id("com.apollographql.apollo3.external")
plugin rather than the usual
id("com.apollographql.apollo3")
)
thank you color 1
👀 1
m

mbonnin

11/24/2023, 12:23 PM
@goku are you shipping generated code as a public API? I wouldn't recommend this as there may be incompatible changes within the same major version of Apollo Kotlin. We try really hard not to and I don't remember this ever being a problem but this may happen
g

goku

11/24/2023, 12:31 PM
@mbonnin Public within the company. Not exposed to clients. Yes it is possible but Apollo Kotlin changes are not the concern. When we update Apollo Kotlin library we can run integration tests and compare binaries of the generated code. The generated code is consumed by multiple teams at the company and every time binary of the generated code changes they are forced to have the latest of the generated code. A change made by one team effects everyone. I’m trying to make generated code more backward compatible so we don’t have to do library updates as frequently.
m

mbonnin

11/24/2023, 12:39 PM
In your example, you would also need to pass a default age which apollo cannot really guess for you.
nod 1
You could also take a look at multi module so that the team owning the consuming code also owns the query
g

goku

11/24/2023, 12:57 PM
True, I’m looking at that case now. If the parameter doesn’t have default value it doesn’t make sense, or for fragments. You can ignore my comment on that. But input one is important I think. We already do that. Whenever schema changes types in the schema module changes and that effects everyone. I think
Input
is a good example. Adding a new nullable field to schema is a “safe” operation from the point of GQL Schema checks, but it is not safe on the client side since the binary of the generated code changes.
addJvmOverloads
should be added to Input imo.
m

mbonnin

11/24/2023, 1:50 PM
Agree that
addJvmOverloads
should also impact input types. Want to open an issue/open a PR?
PS: if you're using v4, you can also use
generateInputBuilders.set(true)
to workaround this
g

goku

11/25/2023, 2:05 AM
I discovered input builders yesterday but we are not in v4 yet. Once we migrate to v4 I will consider adding it. Created the issue and added some notes: https://github.com/apollographql/apollo-kotlin/issues/5397 I would like to create a PR as well but let me see if can find bandwith.
💙 1