Adding <Droidcon Amman 2024> to Confetti: <https:/...
# confettia
Abdulahi
12/17/2023, 7:06 PMAdding Droidcon Amman 2024 to Confetti: https://github.com/joreilly/Confetti/pull/1058
🎉 3
m
mbonnin
12/17/2023, 9:36 PMIt's there 🎉
❤️ 1
j
John O'Reilly
12/19/2023, 11:10 AMShould that Google Office be there?
John O'Reilly
12/19/2023, 11:11 AMbtw been meaning to add link for directions here.... hopefully can do soon
a
Abdulahi
12/19/2023, 11:37 AMI guess not. I wasn’t particularly sure whether I should’ve added it or not but I ended up doing so since all the other venues had it as well. I’ll open a PR to remove it
j
John O'Reilly
12/19/2023, 11:37 AMYeah, might have been left by accident for others as well
👍 2
John O'Reilly
12/19/2023, 12:50 PM@mbonnin do you remember what should be there?
m
mbonnin
12/19/2023, 1:00 PMDescription of the venue. Can be anything
mbonnin
12/19/2023, 1:02 PMIn the benefit of the doubt, leave it empty. We could probably make it nullable too to skip it in the UI completely
a
Abdulahi
12/19/2023, 9:38 PMRemoving it here: https://github.com/joreilly/Confetti/pull/1068
👍 1
2 Views