Hey guys, does anyone what the syntax would be in conf.yaml to allow multiple hosts in CORS. I trie...

# kobweb

[Dieter Vaesen]

Hey guys, does anyone what the syntax would be in conf.yaml to allow multiple hosts in CORS. I tried the following but it doesn't work. Not really familiar with it

server:
  cors:
    hosts:
      - name: "dieter.onrender.com"
        schemes:
          - "https"
      - name: "dieter.com"
        schemes:
          - "https"

[Christiano]

Have you looked at this already? 😄

https://github.com/varabyte/kobweb?tab=readme-ov-file#configuring-cors

And as far as I can see according to the actual source code, this what you have should suffice 🤔

Cors
Host

[Dieter Vaesen]

yes 🙂. I don't need subdomains 🙂

[Dieter Vaesen]

Maybe my example isn't the best one. I"ll edit it

[Dieter Vaesen]

I'm hosting a kobweb project on render but it also needs to work on a custom domain

[Dieter Vaesen]

Just for test purposes i also tried the subdomains and it doesn't seem like they are working

[David Herman]

Your syntax looks correct. I'm assuming you already saw my blog post which gets something running on render? https://bitspittle.dev/blog/2023/clouddeploy#configure-cors

What error message are you seeing?

[Dieter Vaesen]

Yes I found the blogpost. My last changes are building on render now. Hopefully it will work

[Dieter Vaesen]

Any idea why the subdomains wouldn't work? I'm testing them in Paw at the moment with an "origin" field in the header

[David Herman]

Did you spell it "subDomains" in the yaml? I think I did that because ktor separates "sub" and "domains" but looking at it now it should probably have been "sundomains" one word?

[David Herman]

I'll add support for that

[David Herman]

Otherwise you're making me guess a lot here 😛 putting code snippets and error messages would be really useful

[Dieter Vaesen]

Untitled

Untitled

[Dieter Vaesen]

I did it like this

[Dieter Vaesen]

Screenshot 2023-12-29 at 18.31.56.png,Screenshot 2023-12-29 at 18.32.12.png

[Dieter Vaesen]

If you use

subDomains:

It works

[David Herman]

Ok so just a spelling "error" then

[David Herman]

I'll update so "subdomains" also works in 0.15.4

[Dieter Vaesen]

Maybe also add it to guide and readme of repo?

[Dieter Vaesen]

So other people find it quicker ? Should they be using an older version?

[David Herman]

Ah wait I fixed this already

[David Herman]

What version of Kobweb are you using?

[David Herman]

https://github.com/varabyte/kobweb/blob/75dbae80b1e58d21c939fc844cbd1cbd2017ba95/common/kobweb-common/src/main/kotlin/com/varabyte/kobweb/project/conf/KobwebConf.kt#L190

[David Herman]

Pretty sure I made this change in 0.15.3, thought i was going crazy for a second because I'm juggling a lot these days

[David Herman]

https://github.com/varabyte/kobweb?tab=readme-ov-file#configuring-cors there's even a README section for it

[Dieter Vaesen]

I'm using 0.15.1. So it's a version that doesn't support new syntax

[Dieter Vaesen]

I was using this snippet from the readme.

[David Herman]

You should upgrade to 0.15.3

[Dieter Vaesen]

But what I meant by adding it to the readme was that you could mention that versions before 0.15.3 need to use subDomain. Or you could mention something about upgrading to 0.15.3 if you want to use subdomains correctly.

[David Herman]

Kobweb README is long enough without adding infinite histories to each section

[David Herman]

Kobweb is still pre-1.0 so things should be considered a bit more fluid during this time

[David Herman]

We are pretty careful for most features but yaml is hard because we can't tag things as deprecated

[David Herman]

Best for users to keep up to date and ask questions if things aren't working for now

[Dieter Vaesen]

Ok! Just thought it would be easier for others to find the issue or the reason it's not working.
Thanks for the help!! Everything is working great now!!

[David Herman]

The only user who has ever asked about subdomains is you! It's a pretty niche feature. (And I'm glad you asked here about it)

[David Herman]

Glad you're working. Post-1.0 we'll definitely be a lot more rigorous with the yaml.