Is there supposed to be a difference between using...

# javascript

[Mike Dawson]

Is there supposed to be a difference between using @file:JsModule and @file:JsNonModule , then having an external class / function, and directly annotating the external class/function with @JsModule and @JsNonModule ?

Strangely enough I found when trying to make a wrapper for compressorjs (image compressor), using the file annotations didn't work (kept getting the result as "undefined"). When I put the annotations directly on the external declaration itself, it worked.

[turansky]

@JsNonModule has no sense in 2023 😞

For global/browser external types/functions you need external modifier only
For external types/functions from libraries you need external modifier and @JsModule annotation

[turansky]

In Kotlin Wrappers we have 0 @JsNonModule usages

[Mike Dawson]

I thought if I put @file:JsModule in the file, and then use an external declaration in the same file, that was the same as putting the @JsModule declaration on the external declaration itself

[Mike Dawson]

I think for UMD I can remove the JsNonModule..

[turansky]

AFAIK - UMD will request @JsNonModule

[turansky]

You can use ES or CommonJS module kind to avoid redundant annotation

[Mike Dawson]

Then I would somehow need to tell webpack what version of the npm I want...

[Mike Dawson]

... it seems to have imported the umd version of compressor, although my gradle has useCommonJs()

[turansky]

although my gradle has useCommonJs()

In that case @JsNonModule has zero effect

[Mike Dawson]

Will try removing it and hoping nothing explodes

[Mike Dawson]

Thanks @turansky - seems fine now.