Hey folks, Happy New Year. :tada: I need some hel...

# decompose

[kioko]

Hey folks, Happy New Year. 🎉

I need some help. My app crashes when I open a screen(Show) that I opened before.
If you look at the video, I click on What If, Open Rick and Morty, The Simpsons, and then Family Guy. When I click on The Simpsons, I get the crash. Any pointers?

java.lang.IllegalStateException: Configurations must be unique
       at com.arkivanov.decompose.router.children.ChildrenNavigator.switch(ChildrenNavigator.kt:114)
       at com.arkivanov.decompose.router.children.ChildrenNavigator.navigate(ChildrenNavigator.kt:108)
       at com.arkivanov.decompose.router.children.ChildrenFactoryKt$children$eventObserver$1.invoke(ChildrenFactory.kt:177)
       at com.arkivanov.decompose.router.children.ChildrenFactoryKt$children$eventObserver$1.invoke(ChildrenFactory.kt:174)
       at com.arkivanov.decompose.Relay.drainLoop(Relay.kt:48)
       at com.arkivanov.decompose.Relay.accept(Relay.kt:29)
       at com.arkivanov.decompose.router.stack.DefaultStackNavigation.navigate(DefaultStackNavigation.kt:11)
       at com.arkivanov.decompose.router.stack.StackNavigatorExtKt.push(StackNavigatorExt.kt:20)
       at com.arkivanov.decompose.router.stack.StackNavigatorExtKt.push$default(StackNavigatorExt.kt:19)

CrashDemo.mp4

[Arkadii Ivanov]

You can't have the same (by equality) configuration twice in the stack.

[kioko]

Is there a way to add a “unique” identifier. Say an id or something? If not, how can I fix this? It's an edge case but it would be great not to crash.

[Arkadii Ivanov]

You can either generate a unique id for your needs (e.g. uuid), or perhaps the following would work for your case:

navigate { (it + MyConfig(...)).asReversed().distinct().asReversed() }

[Arkadii Ivanov]

I could add an extension for this case.

[kioko]

That would be great. 🙂 I’ll try out the suggestion above

[Arkadii Ivanov]

Let me know how it works!

[Dennis]

as a suggestion instead of using navigation.push you can also use navigation.bringtofront to avoid configuration duplication

[Arkadii Ivanov]

bringToFront only allows one configuration of the specified class in the stack. As far as I understand, in this case there are multiple - the same screen but with different arguments. I suggest the behaviour as follows: if the specified configuration (by equality) is already presented in the stack, then it's brought to front (to avoid deep stacks with the same screens, like A1-A2-A1-A2-A1-A2), otherwise it's just pushed on top.

[Dennis]

ooh Alright thank you for the clarification Arkadii

[kioko]

Hey @Arkadii Ivanov The suggestion worked. Thanks. blob smile

[Arkadii Ivanov]

Awesome! I will think about adding it to the library.

[Arkadii Ivanov]

I've been thinking about the API for this use case, tried various options. The best I could come up with is as follows:

/**
 * Pushes the provided [configuration] at the top of the stack, removing the [configuration] from the back stack, if any.
 *
 * This API works similar to [bringToFront], except it compares configurations by equality rather than by configuration class.
 * 
 * @param onComplete called when the navigation is finished (either synchronously or asynchronously).
 */
@ExperimentalDecomposeApi
fun <C : Any> StackNavigator<C>.pushToFront(
    configuration: C,
    onComplete: () -> Unit = {},
) {
    navigate(
        transformer = { stack -> stack - configuration + configuration },
        onComplete = { _, _ -> onComplete() },
    )
}

How do you find this API?

I have also tried adding an argument to bringToFront instead of adding a brand new function. But I didn't like the usage - it's quite verbose. A dedicated function looks better.

[Dennis]

The Api functionality looks great Arkadii

[kioko]

Hey @Arkadii Ivanov, I agree. Having a dedicated function looks better. 😎 It's an edge case, but I appreciate making the effort to add it.

[Arkadii Ivanov]

FYI, pushToFront is released in Decompose 3.0.0-alpha05.

[kioko]

Sweet. I will check it out. Thanks.