```fun onValueChange(phone: String) { viewModelScope.launch { if (phone.length >= 10) re...

# android

[Yusuf Ibragimov]

fun onValueChange(phone: String) {
    viewModelScope.launch {
        if (phone.length >= 10) return@launch
        if (!phone.onlyNumberCheck()) return@launch
        if (uiState.value.screenState == ScreenState.Loading) return@launch

        _phone.emit(phone)
    }
}

vs

fun onValueChange(phone: String) {
        viewModelScope.launch {
            if (
                phone.length >= 10 ||
                !phone.onlyNumberCheck() ||
                uiState.value.screenState == ScreenState.Loading
            ) {
                return@launch
            }

            _phone.emit(phone)
        }
    }

Which is the most suitable style in this case? one if or 3 line if

[ascii]

I prefer (1); more readable. They could also be moved out, though.

[ephemient]

considered when?

[Yusuf Ibragimov]

Maybe But now we are dusscussing which one if reccomended way?

[Pablichjenkov]

I personally dislike placing validation logic or any business logic directly in control flow structures like if/else or the more general when. I like creating a separate function so it looks 1 line per condition.
In above option I would pick 1

[snowstorm6]

I prefer 1. but when is better
https://detekt.dev/docs/rules/style/#returncount

[Yusuf Ibragimov]

thanks everyone for saying their opinions