App update rejected.... wasn't even updating wear ...

# confetti

[John O'Reilly]

App update rejected.... wasn't even updating wear is app :)

[John O'Reilly]

also got this as well

[John O'Reilly]

@yschimke seems very marginal if they're complaining about that screenshot

[yschimke]

Agreed. I'll raise on Monday. I can tweak confetti for now so it will pass review.

[John O'Reilly]

what do you think we need to add to description for the first one?

[yschimke]

Probably just say includes a Wear OS Tile and Complication for showing next talk?

[John O'Reilly]

ok, re-submitted with that....might be lucky

[yschimke]

I'll bump to latest versions, test locally on small and large emulators and see if there is simple fix for clipping.

[yschimke]

I am the absolute most qualified person in the world to implement a responsive Wear app, and I can't get past Play Store reviews.

[yschimke]

🙂

[yschimke]

Large emulator

[yschimke]

Small emulator

[yschimke]

image.png

[yschimke]

It's not accident the chip is nestling against the edges. https://github.com/google/horologist/blob/91b797b563557580968bcc67d8550d1518c8aea0[…]/android/horologist/compose/layout/ScalingLazyColumnDefaults.kt

[John O'Reilly]

That looks same as one I posted above ....barely clipped

[yschimke]

fun calculateVerticalOffsetForChip(
            viewportDiameter: Float,
            horizontalPaddingPercent: Float,
        ): Dp {
            val childViewHeight: Float = ChipDefaults.Height.value
            val childViewWidth: Float = viewportDiameter * (1.0f - (2f * horizontalPaddingPercent))
            val radius = viewportDiameter / 2f
            return (
                radius -
                    sqrt(
                        (radius - childViewHeight + childViewWidth * 0.5f) * (radius - childViewWidth * 0.5f),
                    ) -
                    childViewHeight * 0.5f
                ).dp
        }

[yschimke]

I don't think those are clipped, I think touching the screen.

[yschimke]

But the screenshot they provided looks edited

[yschimke]

With a black ring

[yschimke]

image.png

[John O'Reilly]

@yschimke should changes you've merged make a difference to this? I was going to submit new version if so

[yschimke]

No.

[John O'Reilly]

(I submitted again that time with at least the description change but got rejected for this again)

[yschimke]

But I don't think it's an issue. I'll ask tomorrow.

[yschimke]

I can fudge a fix. But shouldn't have to

[yschimke]

Sounds like it might have been the session list with Cards. I'll reproduce and then put up a fix.

[yschimke]

confetti.mp4

confetti.mp4

[John O'Reilly]

@yschimke this is with latest changes

[yschimke]

Is there a screenshot?

[yschimke]

It should be working for this.

[John O'Reilly]

Yeah, missed that in the email

[yschimke]

I don't understand, I'm asking internally what it's meant to do

[yschimke]

I can't reproduce any issues

[yschimke]

confetti_large.mp4

confetti_large.mp4

[yschimke]

font scaling working, nothing clipping

[yschimke]

image.png

[yschimke]

image.png

[yschimke]

@John O'Reilly I'd suggest disable Wear app until I get to the bottom of whatever they think the issue is. I'm out of ideas.

[John O'Reilly]

I don't think there's any rush anyway....it's interesting that they blocked publication of android app because of that......given that they're managed separately now

[yschimke]

I don't want to comment much on it, but unfortunately it isn't made clear to the reviewer that only the Mobile app changed.

[yschimke]

It's correct. If you bump version and submit, it should pass the review.

[John O'Reilly]

just sent for review