Hello! I found a breaking change on `koin-annotati...

# koin

[Matias Calvo]

Hello!
I found a breaking change on koin-annotations 1.3.1 that is making my compilation fail
🧵 ->

[Matias Calvo]

We’ve recently migrated from 1.3.0 to 1.3.1

[Matias Calvo]

I’ve defined a module in this way

@Module
@ComponentScan("com.xxxx.yyyy.zzz")
internal class DynamicModule

and added to the other modules of this feature like this

val featureAModules = listOf(moduleA, ModuleB, DynamicModule().module)

[Matias Calvo]

When KSP runs, there are some differences between the two versions:

Code generated by 1.3.1

public fun KoinApplication.defaultModule(): KoinApplication = modules(defaultModule)
public val defaultModule : Module = module {
	viewModel() { .... } 
	viewModel() { .... } 
	viewModel() { .... } 
}

Code generated by 1.3.0

internal val com_xxx_yyyy_zzz_DynamicModule : Module = module {
	viewModel() { .... } 
	viewModel() { .... } 
	viewModel() { .... } 
internal val com.xxx.yyyy.zzz.DynamicModule.module : org.koin.core.module.Module get() = com_xxx_yyyy_zzz_DynamicModule

[Matias Calvo]

update:

If I disable the default module, it works well:

ksp {
    arg("KOIN_DEFAULT_MODULE","false")
}

[arnaud.giuliani]

do this difference is in code generated only?

[Matias Calvo]

AFAIK yes, is only there, but if I don’t disable the default module, it impacts the ability to compile the app without errors

[arnaud.giuliani]

in 1.3.0 your code was around com_xxx_yyyy_zzz_DynamicModule and now it's generated in defaultModule right?

[Matias Calvo]

exactly

[Matias Calvo]

as long as I don’t disable the default module, that’s the result

[arnaud.giuliani]

could you isolate a project sample? would save me time to reproduce it 🙏