Screenshot_20240221-074548.png

# confetti

[John O'Reilly]

Screenshot_20240221-074548.png

[John O'Reilly]

@yschimke reported in context of wear os app but would be same thing for android app

[yschimke]

Is Auth broken?

[John O'Reilly]

I think what they're saying is that we didn't provide way for them to sign in (by providing credentials etc)

[John O'Reilly]

@mbonnin I thought we had run in to this when we first added login but maybe not

[yschimke]

Google sign in is automatic

[yschimke]

You don't need anything else

[yschimke]

If PLR succeeds then reviewers should also

[John O'Reilly]

what's PLR?

[John O'Reilly]

Reviewers are unable to:
create accounts or use their own existing accounts to access your app
use free trials to access your app
contact you for more information

[John O'Reilly]

so not sure how they're supposed to then

[yschimke]

Pre launch report

[yschimke]

In play console

[yschimke]

Video of navigating around

[yschimke]

This is all assuming that Auth isn't actually broken

[yschimke]

Recycled key on server etc

[John O'Reilly]

what's expectation for how reviewer should log in to app (using some test google account?)

[yschimke]

Yep.

[yschimke]

It's documented that Google sign in just works

[John O'Reilly]

I'll update App access instructions in console and mention that

[yschimke]

I'll check app and PLR

[yschimke]

Maybe it failed for me. Let me check firebase errors and also my watch locally

[John O'Reilly]

it seems to crash when I sign in here

[mbonnin]

Ah I was going to say it worked for me 😅

[mbonnin]

(on Android)

[John O'Reilly]

yeah, can sign in on mobile here as well

[yschimke]

Yep - it's a bug in my network code 😞

[yschimke]

Will fix.

[yschimke]

If blocking you, disable Wear until I can fix.

[yschimke]

1-2 days?

[John O'Reilly]

no, no rush at all

[yschimke]

thanks for your patience then. I really appreciate it.

[John O'Reilly]

hopefully we've been able at least to provide some good feedback on review process 😃

[yschimke]

200%

[John O'Reilly]

Almost feels like you need to submit apps for review every now and then even if no changes 🙂

[yschimke]

I did break this, I didn't test login, locally it's harder without having your keys setup.

[John O'Reilly]

for that login stuff, yeah....but other things seem to be related to changes in policy or maybe stricter enforcment of them

[John O'Reilly]

Hmm, looks like it was accepted just now (I updated the app access info that time)

[yschimke]

The fix - made a temporary copy of one class to avoid waiting on a release https://github.com/joreilly/Confetti/pull/1143

[yschimke]

I could repro the issue easily, and working with the fix.

[John O'Reilly]

just published new version to internal testing channel